Optimize title/alt token_replace [#2650804]

Problem/Motivation

Follow-up from #2642764: Speed up via shortcutting token file_entity_file_load since it's based on the code there.

alt/title default to not having token replacement, so when those are left as the default, we can skip token_replace(). This saves a lot of time especially with multiple AJAX file uploads.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#14	optimize_title_alt-2650804-14.patch	1.12 KB	joseph.olstad
#14	7.x-2.x: PHP 7.2 & MySQL 5.5, D7 63 pass
#11	optimize_title_alt-2650804-11.patch	1.01 KB	joseph.olstad
#11	7.x-2.x: PHP 7.2 & MySQL 5.5, D7 63 pass PHP 5.3 & MySQL 5.5, D7 63 pass PHP 5.6 & MySQL 5.5, D7 63 pass PHP 7.1 & MySQL 5.5, D7 63 pass PHP 7 & MySQL 5.5, D7 63 pass PHP 5.5 & MySQL 5.5, D7 63 pass PHP 5.4 & MySQL 5.5, D7 63 pass
#5	optimize_title_alt-2650804-5.patch	947 bytes	marco
#5	7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply
#4	optimize_title_alt-2650804-4.patch	437 bytes	Fabianx
#4	7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply
#3	2650804.patch	922 bytes	catch
#3	7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply
#2	2650804.patch	923 bytes	catch
#2	7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 January 2016 at 11:05

catch created an issue. See original summary.

File	Size
2650804.patch	923 bytes
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply

Comment #3

catch

he/him

English

CreditAttribution: catch at Tag1 Consulting commented 15 January 2016 at 11:09

File	Size
2650804.patch	922 bytes
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply

Comment #4

Fabianx CreditAttribution: Fabianx at Tag1 Consulting commented 27 January 2016 at 16:13

File	Size
optimize_title_alt-2650804-4.patch	437 bytes
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply

A new patch for a new patch in the other issue.

File	Size
optimize_title_alt-2650804-5.patch	947 bytes
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply

Comment #6

joseph.olstad

French

CreditAttribution: joseph.olstad commented 12 October 2018 at 18:17

Status:

Postponed

» Needs review

the related patch in file_entity was committed, so looks like we should have a look at this now.

Comment #7

12 October 2018 at 18:21

The last submitted patch, 3: 2650804.patch, failed testing. View results

Comment #8

12 October 2018 at 18:23

The last submitted patch, 2: 2650804.patch, failed testing. View results

Comment #9

12 October 2018 at 18:23

The last submitted patch, 4: optimize_title_alt-2650804-4.patch, failed testing. View results

Comment #10

12 October 2018 at 18:26

Status:

Needs review

» Needs work

The last submitted patch, 5: optimize_title_alt-2650804-5.patch, failed testing. View results

File	Size
optimize_title_alt-2650804-11.patch	1.01 KB
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 63 pass PHP 5.3 & MySQL 5.5, D7 63 pass PHP 5.6 & MySQL 5.5, D7 63 pass PHP 7.1 & MySQL 5.5, D7 63 pass PHP 7 & MySQL 5.5, D7 63 pass PHP 5.5 & MySQL 5.5, D7 63 pass PHP 5.4 & MySQL 5.5, D7 63 pass

File	Size
2650804.patch	923 bytes
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply
2650804.patch	922 bytes
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply
optimize_title_alt-2650804-4.patch	437 bytes
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply
optimize_title_alt-2650804-5.patch	947 bytes
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply

Comment #12

12 October 2018 at 20:34

Status:

Needs review

» Needs work

The last submitted patch, 11: optimize_title_alt-2650804-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #13

joseph.olstad

French

CreditAttribution: joseph.olstad commented 12 October 2018 at 20:42

marco , can you fix this please?

Call to undefined function file_entity_replace_title()

File	Size
optimize_title_alt-2650804-14.patch	1.12 KB
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 63 pass

File	Size
optimize_title_alt-2650804-11.patch	1.01 KB
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 63 pass PHP 5.3 & MySQL 5.5, D7 63 pass PHP 5.6 & MySQL 5.5, D7 63 pass PHP 7.1 & MySQL 5.5, D7 63 pass PHP 7 & MySQL 5.5, D7 63 pass PHP 5.5 & MySQL 5.5, D7 63 pass PHP 5.4 & MySQL 5.5, D7 63 pass

Comment #15

joseph.olstad

French

CreditAttribution: joseph.olstad commented 27 October 2018 at 04:58

Ok, this patch will start working and passing testing once a tagged release of file_entity with that function is made.
it requires file_entity 7.x-2.23 which has not yet been tagged.

the said function is not present in 7.x-2.22

Comment #16

joseph.olstad

French

CreditAttribution: joseph.olstad commented 27 October 2018 at 04:58

Assigned:	Unassigned	» joseph.olstad
Status:	Needs work	» Postponed

File	Size
optimize_title_alt-2650804-11.patch	1.01 KB
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 63 pass PHP 5.3 & MySQL 5.5, D7 63 pass PHP 5.6 & MySQL 5.5, D7 63 pass PHP 7.1 & MySQL 5.5, D7 63 pass PHP 7 & MySQL 5.5, D7 63 pass PHP 5.5 & MySQL 5.5, D7 63 pass PHP 5.4 & MySQL 5.5, D7 63 pass
optimize_title_alt-2650804-14.patch	1.12 KB
7.x-2.x: PHP 7.2 & MySQL 5.5, D7 63 pass

Comment #18

joseph.olstad

French

CreditAttribution: joseph.olstad commented 27 October 2018 at 05:03

Status:

Postponed

» Needs work

to finish this off, have to first publish file_entity 7.x-2.23 (soon) as well as the 7.x-3.x branch tag that as well

then have to create a hook_requirements to make sure that file_entity has been updated to 7.x-2.23 or 7.x-3.0-tag or higher

Comment #19

joseph.olstad

French

CreditAttribution: joseph.olstad commented 7 November 2018 at 15:56

Status:

Needs work

» Needs review

re-testing this, a tagged release of file_entity is out, these errors should go away, however the patch should have the hook_requirements checks checking for a version of file_entity equal to or greater than (equal or newer than) the current release.