[D7] IBAN Validator

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxencelado1936168git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Some paraview.sh warnings can be solved easily. For example:
Inline comments must end in full-stops, exclamation marks, or question marks.
The closing brace for the class must have an empty line before it.

Manual review:
You'd better change PHP-IBAN library URL from googlecode to github, both in iban.module file and field_validation_iban_validator.inc file, although it redirects automatically.

Automated Review

Issues reported by PAReview.sh: http://pareview.sh/pareview/httpgitdrupalorgsandboxencelado1936168git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: Causes module duplication and/or fragmentation. There is already an IBAN Field module: https://www.drupal.org/project/iban_field

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity. But less than 120 of PHP code lines are written in all of the module files (I believe this is not an issue to consider since the module is using other modules functions).

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) Fix the name of the class to include the module name as reported by the automatic review.

The module was installed and tested and it worked as it shall do in a perfect way.

This review uses the Project Application Review Template.

As for this issue summery it needs to have the following information in separate lines:

• Project Name
• Link to sandbox page
• Description of this project
• Version of Drupal
• Clone command
• Project Name

The class name and README style alone is surely not an application blocker, anything else that you found or should this be RTBC instead?

@klausi

There is no issue reported about the README file, this issue already follows guidelines for in-project documentation.
The only issue that needs a higher reviewer role to check is the duplicate issue. There is already a module for IBAN field (https://www.drupal.org/project/iban_field).

The module was installed, tested and worked perfectly.

Sorry I changed the issue status by mistake.

We don't block applications over duplication. However, it is considered polite to inform users about alternatives. Please take a look at the project page template and consider adding the section "Similar projects and how they are different".

There are still some style/naming issues reported by PAreview, but nothing that blocks promotion.

At 116 lines (including comments and blanks) and 5 functions, it just passes the bar for length and complexity.

There are IMHO no more blockers. Moving to RTBC. Note that promotion will not happen until a git administrator has given this a second set of eyeballs.

Thanks for your contribution, encelado!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.