Facebook changed the working of the Page Plugin see Developer pages

CommentFileSizeAuthor
#15 2648864-15.patch3.16 KBnaveenvalecha
#10 2648864-10.patch3.61 KBnaveenvalecha
#9 2648864-8.x-2.x.patch2.5 KBnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

baekelandt created an issue. See original summary.

baekelandt’s picture

baekelandt CreditAttribution: baekelandt as a volunteer commented
Assigned: Unassigned » baekelandt

I made a quick draft version, but it needs some cleanup so I'm not committing in yet.

  • baekelandt committed 4629cbf on 7.x-2.x 
    git commit -m 'Issue #2648864 by baekelandt: Update to use new data-tabs...
baekelandt’s picture

baekelandt CreditAttribution: baekelandt as a volunteer commented
Status: Active » Fixed
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Fixed » Active

A patch needed for 8.x-2.x

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Issue tags: +Novice
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented

@baekelandt,
have u completed whole implementation of new changes in 7.x-2.x. Should we port this into 8.x-2.x ?

baekelandt’s picture

baekelandt CreditAttribution: baekelandt as a volunteer commented

Yes, I fully implemented the new data-tabs attribute that replaces the data-show-posts attribute which is now depricated.
And indeed because the data-show-posts attribute, we should also implement the data-tabs into 8.x-2.x so the module keeps working.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Assigned: baekelandt » naveenvalecha
Status: Active » Needs review
FileSize
2648864-8.x-2.x.patch2.5 KB

@baekelandt,
has this mistakenly removed this the commit http://cgit.drupalcode.org/fb_likebox/commit/?id=4629cbf

-  $block['root-div'] = array(
-    '#type' => 'container',
-    '#attributes' => array(
-      'id' => array('fb-root'),
-    ),
-  );
-

Patch attached for 8.x-2.x, Please test, review, lemme know if I missed anything

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
FileSize
2648864-10.patch3.61 KB

Added update path

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs review » Fixed

Committed.

  • naveenvalecha committed 63c006e on 8.x-2.x 
    Issue #2648864 by naveenvalecha: Update to use new data-tabs instead of...
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Fixed » Needs work

The tests failed b/c default configuration values were missing.

  • naveenvalecha committed e882da9 on 8.x-2.x 
    Revert "Issue #2648864 by naveenvalecha: Update to use new data-tabs...
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs work » Needs review
FileSize
2648864-15.patch3.16 KB

The update hook is not required b/c we are not updating the default values.

  • naveenvalecha committed d3f5f82 on 8.x-2.x 
    Issue #2648864 by naveenvalecha: Update to use new data-tabs instead of...
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs review » Fixed

Bot is happy now :)
Committed and pushed.

The last submitted patch, 10: 2648864-10.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.