Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi,
Currently this module is not available for D8, I would like to assist you in developing its drupal 8 version.
I have already started working on this here is the link
https://github.com/imamit123/menu_visiblity_item/tree/8.x-1.x
Thanks
Amit.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2648016-menu_item_visibility-8.x-1.x-2.patch | 15.43 KB | rjjakes |
Comments
Comment #2
amit.drupal CreditAttribution: amit.drupal at gai Technologies Pvt Ltd commentedComment #3
KittenDestroyer CreditAttribution: KittenDestroyer as a volunteer commentedGood day.
I just wanted to clarify if someone is working on this issue. If not, I can start working on porting to Drupal 8.
Comment #4
amit.drupal CreditAttribution: amit.drupal at gai Technologies Pvt Ltd commentedYes. please start working on porting to Drupal 8. i also want to be part of this porting activity.
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedThere is already a port, but the developer needs maintainer access look here https://www.drupal.org/project/issues/2723079
Comment #6
joelpittetHave you tested either of them, are they working in some degree?
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedYes I installed this one from the issue queue https://www.drupal.org/node/2786095. Additionally I changed one line of code regarding the form display . Just a minor thing.
I opened 2 bug reports. One about the missing views support and another for the checkbox warning. Anyway it looks like a good starting point for a dev release.
I couldn't finish my menu item visibility test yesterday, because it was to late for me. I know this is the main functionality , maybe you can test this today or will do this later this day.
Comment #8
rjjakes CreditAttribution: rjjakes commentedI don't understand why a new sandbox module was created and there's .zip files flying around instead of just creating a patch here against the 7.x-1.x branch?
Anyway. I have taken the code from: https://www.drupal.org/node/2786095 and made the following changes:
- Deprecated db_select() calls now use: \Drupal::database()->select()
- Checkbox warning bug is now resolved.
- README.txt is now in the correct format.
- Minor code style changes to match PAReview.sh
Checkout the 7.x-1.x dev branch of this module (not the sandbox one) and run:
patch -p1 < 2648016-menu_item_visibility-8.x-1.x-2.patchMaintainers, can you please create a 8.x-1.x branch or just add me as a maintainer so I can do this and we can get the 8.x-1.x version worked on in the correct way.
Credits for this initial commit need to go to:
https://www.drupal.org/u/sarah-ravikumar
https://www.drupal.org/u/deriboy
https://www.drupal.org/u/almare
https://www.drupal.org/u/rjjakes
Comment #9
rjjakes CreditAttribution: rjjakes commentedComment #10
rcodina CreditAttribution: rcodina commentedI agree with @rjjakes. Please, create an 8 branch of this module here.
Comment #11
joelpittetI ran
phpcbf --standard=Drupalover the patch in #8 and created a new 8.x-1.x branch. Feel free to write patches to fix anything.Not exactly sure why there is all the schema changes were all about from 7.x. I reverted them. There is no
'table' => 'menu',table for the foreign key, and there is no'menu_links'either, I'm guessing it's'menu_tree'now but haven't looked deep enough.I've commented out the schema so I don't have to write a bunch of hook updates when we fix that, so to try this out uncomment that in the install file on the 8.x branch.
Thanks @rjjakes for posting a patch
Comment #13
rjjakes CreditAttribution: rjjakes commentedThanks @joelpittet
I'll check it out and post patches as needed.