Correct UUID handling in Panelizer [#2647890]

Currently, when a fieldable panels pane is added to a panels page an the UUID module is on, it will only use the UUID if the entity is marked as being reuseable. The author of the code in question even leaves a comment acknowledging that this step isn't really figured out, and proposes that perhaps we should be using the vuuid, but opts to go with vid instead, since vuuid wasn't working.

The reason why vuuid doesn't work is because vuuid isn't a base column in the fieldable_panels_panes table, which Panelizer and Panels expect in order to summon panes.

The correct behavior is to use UUID in ALL cases when the UUID module exists.

Comment	File	Size	Author
#8	fieldable_panels_panes-uuid_behavior_correction-2647890-8.patch	683 bytes	CoderBrandon
#8
#2	fieldable_panels_panes-uuid_behavior_correction-2647890-2.patch	1.57 KB	mrmikedewolf
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch failed to apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

11 January 2016 at 05:06

mrmikedewolf created an issue. See original summary.

Comment #2

mrmikedewolf CreditAttribution: mrmikedewolf at Third and Grove commented 11 January 2016 at 05:06

File	Size
fieldable_panels_panes-uuid_behavior_correction-2647890-2.patch	1.57 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch failed to apply

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 March 2016 at 13:53

Status:

Active

» Needs review

Thanks for the patch, I'll review it shortly.

BTW when you upload a patch please set the status to "needs review", that will make the testbot review the code and let others know there's something to review.

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 March 2016 at 13:54

I really wonder if we should just drop the fpid and vid fields entirely and instead just use uuid and vuuid? It seems redundant to support both, especially when CTools now has UUID support.