Path in configuration option for js files is wrong

The path is not technically incorrect for being in /sites/all. However for me, I have superfish under /modules/contrib/superfish which means the references to the relative path ../../sites/all does not work properly and the files don't load. I changed to /sites/all in my libraries.yml file and everything is fixed. I don't really mind whether this module decides to look for the libraries in /sites/all/libraries or in /libraries.

In the documentation it has the default directory as 'sites/all/libraries' so if we change this here we ought to change it there also.

Though it really doesn't affect anything as in the end this path can be configured through the configuration page.

My comment is in regards to the relative directory reference being incorrect...

The code looks for the library at ../../sites/all/libraries However, that will not work if the module is installed in a subdirectory of modules folder. this needs to be fixed.

@nicholas.alipaz the configuration page lets you define the directory of the library, did you try using that?
I havent tried messing with it so not sure if it works correctly.

therealssj, hmm I hadn't noticed that. However, if I remember correctly, I couldn't actually install the module since it won't install when the library is missing (or maybe I am remembering this wrong). I had to edit http://cgit.drupalcode.org/superfish/tree/superfish.libraries.yml?id=c90... to remove all the relative paths in order to install and still keep my module at `/modules/contrib/superfish`. I changed all paths to be from the root, `/sites/all/libraries/...`

(the "configuration" page for this module has been removed; automatic library path detection was added instead)