Follow-up to #353170: Update for latest query builder (Notifications 6.x-dev)

As mentioned in the above ticket, and #360291: Enabling og_notifications breaks latest version of notification.module, OG Notifications 6.x-2.x-dev doesn't work with Notifications 6.x-4.x-dev.

The previous workaround was to downgrade back to Notifications 6.x-2.x and apply some patches, I've got too much time already invested in the current setup so I figured I'd investigate and see if i could get all the "latest greatest" versions at least working.

For now, I've narrowed the primary problem down to the notifications are not getting queued up because the query is not getting properly built.

The query builder returned by og_notifications_notifications() is no longer being called, because the 'query' operation has moved from hook_notifications() into hook_notifications_event() as a result of various changes in the Notifications package version 4.x.

The fix is actually quite trivial, once I was able to find it.

Now, there may be more changes that are required for proper Notifications 4.x support, so I'm leaving the title of this ticket wide open and may follow up with additional patches.

I realize Drupal 6 is reaching end of life, but I have a client that desperately needs to get their notification system back up and running, before their migration to Drupal 8.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jwilson3 created an issue. See original summary.

jwilson3’s picture

jwilson3’s picture

Status: Active » Needs review
jwilson3’s picture

Current status is that emails are being sent for posts belonging to OG groups, but they're using the notification-event templates instead of the og-notification templates.

This is actually mentioned in a number of existing issues, but I can't honestly tell if this was ever properly resolved for event the notifications 6.x-2.x integration.

#388212: OG Notifications template not working
#460944: Messaging Templates: are they working?
#462526: Cant get template for 'OG notifications for new content' to work. (Template for nodecreation works instead)
#553044: OG Notifications not include body from Message template for OG notifications for new content
#553154: Inconsistent use of Notifications v OG Notifications templates