Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If a number has already been confirmed,
clicking "Delete & Start Over" nothing happens.
I propose this change:
file sms_user.module line 273,
replace
$output['opt_out_form'] = drupal_get_form('sms_user_opt_out_form', $account);
with
$output2 = Array();
$output2['mobileform'] = $output;
$output2['opt_out_form'] = drupal_get_form('sms_user_opt_out_form', $account);
$output = $output2;
Comment | File | Size | Author |
---|---|---|---|
#4 | 2645952-4-fail.patch | 3.5 KB | almaudoh |
| |||
#2 | 2645952-fail.patch | 478 bytes | almaudoh |
|
Comments
Comment #2
almaudoh CreditAttribution: almaudoh commentedTweaked the SMS opt out test to expose this bug. Let's see if this patch fails.
Comment #3
almaudoh CreditAttribution: almaudoh commentedThe test obviously didn't work. I have been able to manually replicate this bug,
sleep_time
needs to be disabled whileopt_out
is enabled in the global SMS user settings to have this bug.However, a Drupal web test that replicates those same conditions doesn't fail. I may have to fix this without the test.
Comment #4
almaudoh CreditAttribution: almaudoh commentedTrying to get a failing test patch
Comment #5
almaudoh CreditAttribution: almaudoh commentedAs we don't have BrowserTests on D7 and I'm unable to reproduce this bug in a test using WebtestBase (I have reproduced manually), I'll go ahead to commit the fix without the test, but will leave the issue open for a while.
Comment #7
almaudoh CreditAttribution: almaudoh commentedConsider this fixed.