I just noticed a bug in our plugin dependency removal logic, caused by inconsistent data coming from Core: it seems the inner arrays in $dependencies in onDependencyRemoval() will be keyed (as currently expected in our code) by config name for config/content entities, but they will just be plain, numerically indexed arrays in the case of modules and themes. Since we're currently not testing that case, it slipped through the cracks, and it's of course a bit stupid behavior by Core.

Anyways, once discovered, it's luckily easy to fix.

CommentFileSizeAuthor
#2 2645532-2--fix_module_uninstall_plugin_removal.patch3.51 KBdrunken monkey
#2 2645532-2--fix_module_uninstall_plugin_removal--tests_only.patch2.59 KBdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey for Acquia commented
Status: Active » Needs review
FileSize
2645532-2--fix_module_uninstall_plugin_removal--tests_only.patch2.59 KB
2645532-2--fix_module_uninstall_plugin_removal.patch3.51 KB

The last submitted patch, 2: 2645532-2--fix_module_uninstall_plugin_removal--tests_only.patch, failed testing.

The last submitted patch, 2: 2645532-2--fix_module_uninstall_plugin_removal--tests_only.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ for Acquia commented
Status: Needs review » Reviewed & tested by the community
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey for Acquia commented
Status: Reviewed & tested by the community » Fixed

Thanks for reviewing!
Committed.

  • drunken monkey committed 365f6a7 on 8.x-1.x 
    Issue #2645532 by drunken monkey: Fixed index plugin dependency removal...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.