Overriding values using metatag_panels with a default view causes other metatag values to change. I've noticed this when I've had duplicate tag values, on different metatags even though they weren't changed through the overrides.

I've traced it to a scoping issue with the use of a reference variable, which causes all the tags to be "reset" on a later loop using the same variable name.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kev5873 created an issue. See original summary.

DamienMcKenna’s picture

Version: 7.x-1.7 » 7.x-1.x-dev

FYI I've adding some tests to #2564483: Cannot translate metatags after last update anymore for basic Metatag:Panels integration, it might be useful to extend those tests (once they're committed) to ensure it's working correctly.

DamienMcKenna’s picture

DamienMcKenna’s picture

@kev5873: Please let me know if the patch in #3 solves the problem for you. Thanks.

kev5873’s picture

@DamienMcKenna: Yep patch #3 fixes the issue. Thanks.

DamienMcKenna’s picture

Status: Needs review » Reviewed & tested by the community

@kev5873: Excellent, thanks for letting me know!

DamienMcKenna’s picture

Status: Reviewed & tested by the community » Fixed
Parent issue: » #2657108: Plan for Metatag 7.x-1.12 release

Committed. Thanks!

  • DamienMcKenna committed a562a13 on 7.x-1.x authored by kev5873
    Issue #2644742 by kev5873, DamienMcKenna: Variable scoping issue with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.