Problem/Motivation

\Drupal\config\Tests\ConfigEventsTest::testConfigEvents includes the following call on line 36 but doesn't assign the value to anything, hence the call is redundant.

\Drupal::state()->get('config_events_test.event', FALSE);

Proposed resolution

Remove it

Remaining tasks

Remove it
Review

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 2644216-3.patch733 bytesjordanpagewhite
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan created an issue. See original summary.

jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented
Assigned: Unassigned » jordanpagewhite
jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented
Status: Active » Needs review
FileSize
2644216-3.patch733 bytes

I removed the call on line 36. Let me know if there is anything else to do with this task.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community

Yeah, it was introduced in #2175917: Clean up configuration system events - it doesn't make much sense for it to be there.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 9651352 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed ffb427a on 8.1.x 
    Issue #2644216 by jordanpagewhite: Needless State::get call in \Drupal\...

  • alexpott committed 9651352 on 
    Issue #2644216 by jordanpagewhite: Needless State::get call in \Drupal\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.