I am getting two Webform tab.
Screen is attached.

CommentFileSizeAuthor
#7 2643808-7-remove_double_webform_tabs.patch2 KBfenstrat
#2 two_webform_tabs-webform-2643808-1.patch998 bytesdagmar
Webform tab.jpg26.26 KBashhishhh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ashhishhh created an issue. See original summary.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented
Status: Active » Needs review
FileSize
two_webform_tabs-webform-2643808-1.patch998 bytes

Here is the patch. It seems there are two entries on the webform.routing.yml file. I'm removing the one that is using some weird permissions, the other at bottom of the file was not modified:

entity.node.webform:
  path: '/node/{node}/webform'
  defaults:
    _title: 'Webform'
    _form: '\Drupal\webform\Form\WebformComponentsForm'
  requirements:
    # @todo This needs to call/replicate webform_node_update_access().
    _permission: 'edit webform components'
    _access_check_webform: 'TRUE'
  options:
    _node_operation_route: TRUE

Status: Needs review » Needs work

The last submitted patch, 2: two_webform_tabs-webform-2643808-1.patch, failed testing.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented
Status: Needs work » Needs review

Well, seems the test for 8.x-4.x are not working properly. Back to needs review.

Status: Needs review » Needs work

The last submitted patch, 2: two_webform_tabs-webform-2643808-1.patch, failed testing.

The last submitted patch, 2: two_webform_tabs-webform-2643808-1.patch, failed testing.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
FileSize
2643808-7-remove_double_webform_tabs.patch2 KB

Thanks @dagmar, however there's also a double entry in webform.links.tasks.yml which the attached also removes.

And yes, testing on the 8.x-4.x branch is still totally broken.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Status: Needs work » Fixed

Committed and pushed to 8.x-4.x. Thanks!

  • fenstrat committed c519bc1 on 8.x-4.x 
    Issue #2643808 by dagmar, fenstrat: Fixed there are two Webform tabs on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.