There is a spelling mistake in the Description part of Register users (i.e., auto-provisioning) inside the module file line number 535. Instead of whether its misspelled as wether.

CommentFileSizeAuthor
#9 2643736-9.patch1.67 KBashishdalvi
#4 simplesamlphp_auth-fixed_spelling_mistake-2643736-4.patch1.94 KBtrupti.dixit
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibinjc created an issue. See original summary.

jibinjc’s picture

jibinjc CreditAttribution: jibinjc commented
Issue summary: View changes
trupti.dixit’s picture

trupti.dixit CreditAttribution: trupti.dixit commented
Assigned: Unassigned » trupti.dixit
trupti.dixit’s picture

trupti.dixit CreditAttribution: trupti.dixit as a volunteer and at Faichi Solutions Pvt Ltd commented
FileSize
simplesamlphp_auth-fixed_spelling_mistake-2643736-4.patch1.94 KB

I found this issue in simplesamlphp_auth.admin.inc file at line number 101 and fixed the issue.
-Thanks

madhavvyas’s picture

madhavvyas CreditAttribution: madhavvyas as a volunteer and at CIGNEX commented

Spelling change is correct. I am confirming.

trupti.dixit’s picture

trupti.dixit CreditAttribution: trupti.dixit as a volunteer and at Faichi Solutions Pvt Ltd commented
Status: Active » Needs review
Stevel’s picture

Stevel CreditAttribution: Stevel commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

The patch doesn't apply anymore, but otherwise looks correct. Could you re-roll the patch?

Stevel’s picture

Stevel CreditAttribution: Stevel commented
Version: 7.x-2.0-alpha2 » 7.x-3.x-dev

Updated version, since the code should apply to the branch head.

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
CreditAttribution: ashishdalvi at Blisstering Solutions commented
Status: Needs work » Needs review
FileSize
2643736-9.patch1.67 KB

Rerolled patch with 7.x-3.x version

Stevel’s picture

Stevel CreditAttribution: Stevel commented
Assigned: trupti.dixit » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Looks good, patch applies cleanly, so RTBC

snufkin’s picture

snufkin CreditAttribution: snufkin commented
Status: Reviewed & tested by the community » Fixed

Fixed, thank you.

  • snufkin committed 3a0d051 on 7.x-3.x authored by Ashish.Dalvi 
    Issue #2643736 by trupti.dixit, Ashish.Dalvi: Spelling mistake in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.