If select "Mark group as required if it contains required fields." for the Vertical tab on the settings form it does not work.
Vertical tabs comes from the Drupal core so they do not have such functionality to mark the Vertical tab as required if it contains required fields. In order to fix this we need to add custom js for this. Actually we have such js in module call vertical-tabs.js in the folder formatters/vertical_tabs but it is not used. Also this javascript need to be fixed.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | interdiff-2643558-1-3.txt | 1.83 KB | pixelmord |
| #3 | field_group-vertical-tabs-js-2643558-3.patch | 2.69 KB | pixelmord |
| #2 | field_group-vertical-tabs-js-2643558-1.patch | 3.03 KB | ozin |
Comments
Comment #2
ozinThis patch should be applied after #2643360: Incorrect DrupalSettings are passed to the js..
Comment #3
pixelmord commentedHi, I tried the patch #1 and ran in an issue that with more than one vertical tab one of the
$(this).data('verticalTab').linkin the collection was not defined (yet) and so execution was aborted due to the error thrown.Also I think that looking for '.form-required' class as a test for required fields is not safe due to the fact that one could possible change those classes in the templates. So I think that searching for the required attribute on the input is safer.
Lastly I had to change the patch code for Tabs.php to be applicable for current HEAD.
Please review.
BTW. I think something similar should happen for the horizontal tab panes, I will try to search if an issue for this already exists.
Comment #5
nils.destoop commentedSame like in #2643382: Implementation of Drupal.FieldGroup.processHook() does not work for the horizontal tabs. :)
Comment #9
aspilicious commented