Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AohRveTPV created an issue. See original summary.

nerdstein’s picture

Assigned: Unassigned » nerdstein

What are the steps to reproduce? I just want to make sure I am seeing the same thing.

nerdstein’s picture

for review

AohRveTPV’s picture

I think the steps were to try to register a new account with the default Drupal settings.

The patch might not work for all configurations. I think there is a combination of settings where the password fields do appear on the user registration form (e-mail verification and administrator approval not required?). An administrator may want a password policy to be applied for them.

I can check later and report back. Don't have access to a D8 installation currently.

nerdstein’s picture

I tested the use case and it worked for me. If there are more, let me know.

AohRveTPV’s picture

Status: Needs review » Needs work

Thanks. The patch seems to fix the problem I reported. However, it causes the policy/constraints table to disappear on the user registration form with the following settings:

Administration > Configuration > People > Account settings > Registration and cancellation:
Who can register accounts?: Visitors
Require e-mail verification when a visitor creates an account: unchecked

Validation versus policies still occurs upon form submission.

nerdstein’s picture

I'll take a look at that

mxr576’s picture

I think my patch contains a better solution for this issue, because the main problem here is the "Require e-mail verification when a visitor creates an account: checked" settings.

mxr576’s picture

nerdstein’s picture

Reviewed #9 and will be committed up this weekend.

mahalingam_cs’s picture

Status: Needs review » Reviewed & tested by the community

Patch work for me and the issue is fixed.

nerdstein’s picture

#9 patch is too overreaching. There needs to be additional conditions to only apply the verify mail config during registration and not globally. New patch applied.

  • nerdstein committed 451c37b on 8.x-3.x
    Issue #2643460 by nerdstein, mxr576: Can't create new account when e-...
nerdstein’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 12: password_policy-registration_form-2643460-12-8.x-3.x.patch, failed testing.

nerdstein’s picture

Status: Needs work » Fixed

This is working, not sure why it was pushed back

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.