Comments

Chi created an issue. See original summary.

Chi’s picture

Status: Active » Needs review
FileSize
1.77 KB
Chi’s picture

Version: 8.1.x-dev » 8.0.x-dev

I also propose moving comment-entity-form.js to comment/js directory where all other comment js files live.

Chi’s picture

Vertical tabs are not used for a long time. Have not idea how I managed to test this patch.

Chi’s picture

Vertical tabs are not used for a long time.

Well, they were replaced only in Seven theme.

dawehner’s picture

Status: Needs review » Needs work

Afaik we no longer use classes but rather data-drupal-selector instead.

Chi’s picture

Status: Needs work » Needs review
FileSize
1.61 KB
Chi’s picture

Status: Needs review » Needs work

The last submitted patch, 8: comment_behaviour_on_entity_settings_form-2643240-8.patch, failed testing.

Chi’s picture

Version: 8.0.x-dev » 8.1.x-dev
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: comment_behaviour_on_entity_settings_form-2643240-8.patch, failed testing.

The last submitted patch, 8: comment_behaviour_on_entity_settings_form-2643240-8.patch, failed testing.

Chi’s picture

Version: 8.1.x-dev » 8.0.x-dev
Status: Needs work » Needs review

Back to 8.0.x.

Status: Needs review » Needs work

The last submitted patch, 13: comment_behaviour_on_entity_settings_form-2643240-11.patch, failed testing.

Chi’s picture

Chi’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 16: comment_behaviour_on_entity_settings_form-2643240-16.patch, failed testing.

Chi’s picture

Version: 8.0.x-dev » 8.1.x-dev
Status: Needs work » Needs review

The patch failed to apply on 8.0.x because of #2672200: Wrap Drupal with closure variable .

Status: Needs review » Needs work

The last submitted patch, 16: comment_behaviour_on_entity_settings_form-2643240-16.patch, failed testing.

Chi’s picture

Status: Needs work » Needs review

Notice that Drupal.checkPlain() was removed because that setting may have only three predefined value (Open, Closed, Hidden).

Chi’s picture

Status: Needs review » Needs work

The last submitted patch, 22: comment_behaviour_on_entity_settings_form-2643240-22.patch, failed testing.

The last submitted patch, 22: comment_behaviour_on_entity_settings_form-2643240-22.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 25: comment_behaviour_on_entity_settings_form-2643240-25.patch, failed testing.

The last submitted patch, 25: comment_behaviour_on_entity_settings_form-2643240-25.patch, failed testing.

Chi’s picture

Status: Needs work » Needs review

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

droplet’s picture

Status: Needs review » Needs work
+++ b/core/modules/comment/comment.libraries.yml
@@ -1,7 +1,7 @@
-    comment-entity-form.js: {}
+    js/comment-entity-form.js: {}

We can't change the Path unfortunately.

#2484623: Move all JS in modules to a js/ folder

Chi’s picture

We can't change the Path unfortunately.

I don't think we would break BC here because comment-entity-form.js is completely useless for a very long time. However I will move the file back to keep the patch up to the issue scope.

Chi’s picture

+++ b/core/modules/comment/js/comment-entity-form.js
@@ -0,0 +1,23 @@
+      $context.find('[data-drupal-selector="edit-comment-0"]').drupalSetSummary(function (context) {

It turns out that "comment" here stands for field name not for module name as I thought. I've updated the path to avoid hardcoded field name and delta.

Chi’s picture

Status: Needs work » Needs review
Pavan B S’s picture

Status: Needs review » Needs work

The last submitted patch, 35: comment_behaviour_on_entity_settings_form-2643240-35.patch, failed testing.

tameeshb’s picture

Status: Needs work » Needs review
FileSize
4.58 KB
1.03 KB

Rectifying error on patch from #35

Status: Needs review » Needs work

The last submitted patch, 37: 624368-37.patch, failed testing.

Jo Fitzgerald’s picture

Status: Needs work » Needs review
FileSize
4.56 KB
370 bytes

Corrected indentation (3rd time lucky?)

droplet’s picture

Can we add a test for multiple Comment type (fields)?

tedbow’s picture

Ok rerolled

Also fixed standards issue with test, indentation and array syntax
Add changes to es6.js need since [#2815083]

Added "Needs issue summary update" tag because it doesn't say what the problem is. I couldn't really test/check.

Status: Needs review » Needs work

The last submitted patch, 41: 2643240-41.patch, failed testing. View results

tedbow’s picture

Status: Needs work » Needs review

Not sure why the patch still went against 8.3.x. Applying to 8.4.x