This module allows images to be captured from a webcam and uploaded to the server. It provides a field API widget for file and image fields, as well as a form element for module developers.
To capture images this module requires a browser that supports getUserMedia.
Project page
Git clone url
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/mdryan/2096387.git webcam_snapshot
Automated review
No test cases (and not sure how this could be usefully tested programmatically), but otherwise gets a clean bill of health from pareview.sh.
Notes
- I am an individual d.o account holder.
- There doesn't appear to be another module which does the same thing as noted in the issue queue. A subsequent issue suggested releasing this as a full project (I've since fixed the branch names as well as tidying up some of the code for release).
- I wrote the code and am happy to release it as GPL version 2 or later.
- There are no third party libraries.
- The README.txt file is based on the recommended template.
- Although much of the interesting code is in the javascript, I believe it meets the complexity requirements.
- I believe the code meets the security requirements.
- I have attempted to follow Drupal coding style and make use of the Drupal API where possible.
Manual reviews of other projects
(for PAReview: review bonus tag)
Comments
Comment #2
mdryanComment #3
fishfree CreditAttribution: fishfree as a volunteer commentedNotice: Undefined property: stdClass::$metadata in webcam_snapshot_field_widget_form_value_callback() (line 250 of /home/wzzhang/www/data/sites/all/modules/contrib/webcam_snapshot/webcam_snapshot.module).
Notice: Undefined property: stdClass::$metadata in webcam_snapshot_field_widget_form_value_callback() (line 250 of /home/wzzhang/www/data/sites/all/modules/contrib/webcam_snapshot/webcam_snapshot.module).
Change the line 250 and 251 to as below, the warnings disappeared:
I'm building a web-based human-face detection & meeting registering system these days, so searched out your module. Hope it will be promoted to a full project soon.
Comment #4
mdryanThose two E_NOTICE warnings should now be fixed.
I'm not quite sure why I was using the height and width metadata from file_save_data() -- given that we create the image ourselves at a specified size.
Comment #5
mdryanComment #6
attiks CreditAttribution: attiks at Attiks commentedThis all looks solid +1
Comment #7
klausiReview of the 7.x-1.x branch (commit 7790785):
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
manual review:
Otherwise looks good to me.
Thanks for your contribution, Matt!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #8
mdryanMany thanks @klausi. I've fixed those points, upgraded the project and will try and find time to check back and review a few other full project applications in the future.