Follow up for #2642024: Gateway instances as config entities

Improve namespace and class naming for SmsGateway config entities and SmsGateway plugins to reduce developer confusion.

CommentFileSizeAuthor
#14 improve_ns_and_naming-2642950-14.patch23.33 KBalmaudoh
#14 interdiff.txt11.75 KBalmaudoh
#13 improve_ns_and_naming-2642950-13.patch23.15 KBalmaudoh
#13 interdiff.txt1.34 KBalmaudoh
#10 improve_ns_and_naming-2642950-10.patch22.88 KBalmaudoh
#10 interdiff.txt6.56 KBalmaudoh
#6 improve_ns_and_naming-2642950-6.patch25.41 KBalmaudoh
#6 interdiff.txt996 bytesalmaudoh
#3 improve_ns_and_naming-2642950-3.patch24.65 KBalmaudoh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpi created an issue. See original summary.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Postponed » Active

Having committed #2642024: Gateway instances as config entities, this can now continue.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Active » Needs review
FileSize
improve_ns_and_naming-2642950-3.patch24.65 KB

A starting patch...let's see what breaks.

Status: Needs review » Needs work

The last submitted patch, 3: improve_ns_and_naming-2642950-3.patch, failed testing.

The last submitted patch, 3: improve_ns_and_naming-2642950-3.patch, failed testing.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs work » Needs review
FileSize
interdiff.txt996 bytes
improve_ns_and_naming-2642950-6.patch25.41 KB

Missed the new class name in plugin manager constructor...

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Needs review » Reviewed & tested by the community

All around good improvements!

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Reviewed & tested by the community » Needs work

Just occurred to me that the 'Gateway' directories should be renamed to 'SmsGateway'.

  • Plugins directories: eg: 'src/Plugin/Gateway/' -> 'src/Plugin/SmsGateway/'.
  • Service, and plugin base and interface directory: 'src/Plugin/Gateway/' -> 'src/Plugin/SmsGateway/'
dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Assigned: dpi » Unassigned
almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs work » Needs review
FileSize
interdiff.txt6.56 KB
improve_ns_and_naming-2642950-10.patch22.88 KB

Re-rolled patch after #2643252: Transfer Default gateway settings to DefaultSmsProvider and made additional changes per #8.1 for src/Plugin/SmsGateway. For src/Gateway, I would prefer to leave as is to reduce verbosity, or alternatively move the plugin classes to src/Plugin

Status: Needs review » Needs work

The last submitted patch, 10: improve_ns_and_naming-2642950-10.patch, failed testing.

The last submitted patch, 10: improve_ns_and_naming-2642950-10.patch, failed testing.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.34 KB
improve_ns_and_naming-2642950-13.patch23.15 KB

Namespaces missed by IDE's automatic refactoring.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
FileSize
interdiff.txt11.75 KB
improve_ns_and_naming-2642950-14.patch23.33 KB

Moved plugin classes to src/Plugin...

Still contemplating a better replacement for SmsGatewayInterface::getPlugin()

Status: Needs review » Needs work

The last submitted patch, 14: improve_ns_and_naming-2642950-14.patch, failed testing.

The last submitted patch, 14: improve_ns_and_naming-2642950-14.patch, failed testing.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs work » Needs review

Strange... :/

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs review » Fixed

I think I'll commit this as is for now to unblock other improvements. Committed / pushed to 8.x-1.x.

  • almaudoh committed 46f2996 on 8.x-1.x 
    Issue #2642950 by almaudoh: Improve NS and naming of SmsGateway config...
dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

Good work!

++

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.