Follow-up to #2451411: Add libraries-override to themes' *.info.yml

Problem/Motivation

I have added this libraries-override to my theme:

libraries-override:
  core/html5shiv: yaml/html5shiv.printshiv
  core/normalize: false

and now I searched the source code for normalize and ,core\/html5shiv,core\/normalize, is found. Since I have replaced the one lib is should be updated to yaml/html5shiv.printshiv and the core/normalize need to be removed.

Proposed resolution

Fix the broken libraries array in DrupalSettings.

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

hass created an issue. See original summary.

hass’s picture

Issue summary: View changes

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

Priority: Major » Normal
Status: Active » Needs review
FileSize
2.24 KB

The core committers (@xjm, @alexpott, @catch, @effulgentsia, @Cottser) and theme maintainers (@lauriii, @joelpittet) discussed this issue on April 27th regarding major issues in the theme system.

We were trying to see if there was really major issue here and I think we need more information to that effect. Could you explain why this is a major issue @hass? I can reproduce your issue so that is great but I don't see how this is major and not just normal.

I'm going to send back to normal priority until someone can explain the majorness but also I have a patch to hopefully help resolve the issue in question.

lauriii’s picture

Component: theme system » javascript
Status: Needs review » Postponed
Issue tags: +Needs subsystem maintainer review

I'd like to get feedback from the Javascript subsystem maintainers what is this feature used for? This would help us to figure out what is the expected behavior.

joelpittet’s picture

Component: javascript » theme system
Status: Postponed » Needs review
Issue tags: +Needs tests

Needs automated regression testing as well. Though I'd like to know what the point of outputing the libraries into the HTML response is being used for as well.

lauriii’s picture

Component: theme system » javascript

Switching back for the review

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

nod_’s picture

Status: Needs review » Closed (works as designed)
Issue tags: -Needs subsystem maintainer review

I would need some more time to look this up but it's present in drupalSettings for the ajax framework to do it's job.

The list of libs is used to figure out what else the ajax framework needs to load. Having them on the page means that the ajax framework doesn't need to load those 2 again. The first one was overridden and properly overridden. The second one hasn't been loaded but tricks the ajax framework into not loading it in a future request.

Unless the wrong files are loaded this is not a bug.

joelpittet’s picture

Component: javascript » asset library system
Status: Closed (works as designed) » Needs review

@nod_ If it's overridden to be removed, it shouldn't show in the markup.

nod_’s picture

I'd say javascript is not markup and wiggle out of this predicament. It's not in my queue anymore so if people feel like doing some PHP, I won't stop them :)

joelpittet’s picture

Thanks for your feedback @nod_, still valuable in it's own right but I think we need to resolve this and that's also why I moved it out of your queue;) Thanks to the fuzziness that are lines between our components:P

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.