Follow-up to #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class
Problem/Motivation
According to #2346261: Deprecate entity_create() in favor of a <EntityType>::create($values) or \Drupal::entityManager()->getStorage($entity_type)->create($values), entity_create() function is going to be deprecated so we shouldn't use it anymore. When the entity type is known we should directly call <EntityType>::create()
. What to do when the entity type is not known or is variable is upon discussions.
Beta phase evaluation
Issue category | Task |
---|---|
Issue priority | Normal because it's just about code cleanup and good practices |
Prioritized changes | The main goal of this issue is DX, performance and removing code already deprecated for 8.0.0. (Direct calls to EntityType::create are better than generic calls to entity_create for readability) |
Disruption | This change is not disruptive at all as it only replaces deprecated functions call by their exact equivalent. |
Proposed resolution
Replace the deprecated call to entity_create()
by a proper call to <EntityType>::create()
.
Before:
entity_create('field_config', $field_values)->save();
After:
use Drupal\field\Entity\FieldConfig;
FieldConfig::create($field_values)->save();
Remaining tasks
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Create a patch | Instructions | Done | |
Manually test the patch | Novice | Instructions | |
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#18 | interdiff-2641624-14-18.txt | 482 bytes | heykarthikwithu |
#18 | 2641624-18.patch | 14.4 KB | heykarthikwithu |
#14 | interdiff-2641624-10-14.txt | 9.43 KB | heykarthikwithu |
#14 | 2641624-14.patch | 14.39 KB | heykarthikwithu |
#12 | Screen Shot 2016-02-15 at 19.47.19.png | 131.14 KB | naveenvalecha |
Comments
Comment #2
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedComment #4
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedIt was missing class aliasing
Comment #5
Mile23Patch no longer applies.
Comment #6
kostyashupenkoLooks like bad reroll
Comment #7
kostyashupenkoComment #9
heykarthikwithuworking on this.
Comment #10
heykarthikwithuComment #11
heykarthikwithuComment #12
naveenvalechaStill we have
entity_create('user
left in following :Comment #13
heykarthikwithuComment #14
heykarthikwithuComment #15
naveenvalechaMy IDE did not find any occurance of
entity_create('user
and happy now.Thanks!
Comment #17
heykarthikwithuComment #18
heykarthikwithuComment #19
naveenvalecha#18, Thanks! back to RTBC
Comment #21
catchCommitted/pushed to 8.1.x, thanks!
Comment #22
naveenvalechacool! we have now few more left to close meta :)