Problem/Motivation

We moved token tree builder functions to a service in #2641076: Move token builder functions to a service. We didn't remove the functions in that issue to check for more effects. Let's do that in this follow-up.

Proposed resolution

Remove functions:

  1. token_build_tree

Remaining tasks

Patch, Review and Commit

User interface changes

None

API changes

The deprecated functions may not be used anymore. Callers should directly use the @token.tree_builder service.

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

Status: Active » Needs review
FileSize
1.13 KB

This is almost certainly going to fail, but let's worry about this issue after we close a few other pressing issues first. :)

I am attaching the patch for later reference.

hussainweb’s picture

Status: Needs review » Needs work

Wow, it passed. It shouldn't really. There are quite a few usages of token_tree_build. #2641136: Write tests for token tree builder will help.

The last submitted patch, 2: remove_deprecated_tree_builder-2641386-2.patch, failed testing.

Berdir’s picture

Yay test fails! ;)

hussainweb’s picture

Status: Needs work » Needs review
FileSize
3.31 KB

Yay! Let's fix them now. Skipping interdiff as the previous change was quite small.

hussainweb’s picture

BTW, I manually tested various pages (help, autocomplete, token browser dialog). All work fine.

Berdir’s picture

Status: Needs review » Fixed

Thank you, committed.

  • Berdir committed 2bd27c0 on 8.x-1.x authored by hussainweb
    Issue #2641386 by hussainweb: Remove @deprecated token tree builder...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.