Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The dialog option for token browser is not used and is going to be removed as per #2640138: Use token_tree_link instead of token_tree to render links. There are three places where the token tree is called but only one of them is intended as a link. We should use the proper theme function for this link.
Proposed resolution
Change the theme call.
Remaining tasks
Patch, review, commit
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#4 | remove_dialog_option-2640258-4.patch | 2.41 KB | hussainweb |
|
Comments
Comment #2
hussainwebHere is the patch which changes the call to theme('token_tree_link'). I tested this manually and it works fine.
Comment #3
BerdirLets change the others too. We should always use the dialog unless there is a very good reason not to.
Comment #4
hussainwebI see why it was showing the token browser directly before, but I agree that they are not really strong reasons. Removing them. I am moving one of them slightly to give better placement with the textbox. It's a small enough patch, so skipping interdiff. I hope that is fine.
Comment #5
BerdirThanks, committed.