Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
PHPDoc requires improvement for following function:
-
function theme_webform_view($variables)
-
function theme_webform_view_messages($variables)
-
function theme_webform_mail_headers($variables)
All these functions are using $variable as parameter.
But PHPDoc are talking about it's keys.
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff-2640178-2-7.txt | 470 bytes | klidifia |
#7 | 2640178-webform-docblock-fixes-7.patch | 3.38 KB | klidifia |
| |||
#5 | 2640178-failed-patch-re-rolled-5.patch | 3.64 KB | shabirahmad |
| |||
#2 | 2640178-2.patch | 3.49 KB | klidifia |
Comments
Comment #2
klidifia CreditAttribution: klidifia as a volunteer commentedUpdated PHPDoc for the functions.
Comment #3
shabirahmad CreditAttribution: shabirahmad as a volunteer commentedRe-rolled the patch
Comment #5
shabirahmad CreditAttribution: shabirahmad as a volunteer commentedRe-rolled the patch
Comment #7
klidifia CreditAttribution: klidifia as a volunteer commentedI don't think the theme hooks need to have the $variables as a param in the docblock, this doesn't happen anywhere in core.
This is the same as #2 but I changed the comment to be one line like in #5.
Comment #9
fenstratClosing to clear out the old Webform 8.x-4.x branch. See #2827845: [roadmap] YAML Form 8.x-1.x to Webform 8.x-5.x.