PHPDoc requires improvement for following function:

  1. function theme_webform_view($variables)
    
  2. function theme_webform_view_messages($variables) 
    
  3. function theme_webform_mail_headers($variables)  
    

All these functions are using $variable as parameter.
But PHPDoc are talking about it's keys.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ashhishhh created an issue. See original summary.

klidifia’s picture

FileSize
3.49 KB

Updated PHPDoc for the functions.

shabirahmad’s picture

Status: Needs work » Needs review
FileSize
3.64 KB

Re-rolled the patch

Status: Needs review » Needs work

The last submitted patch, 3: 2640178-docblock-webform-fixes-3.patch, failed testing.

shabirahmad’s picture

Status: Needs work » Needs review
FileSize
3.64 KB

Re-rolled the patch

Status: Needs review » Needs work

The last submitted patch, 5: 2640178-failed-patch-re-rolled-5.patch, failed testing.

klidifia’s picture

Status: Needs work » Needs review
FileSize
3.38 KB
470 bytes

I don't think the theme hooks need to have the $variables as a param in the docblock, this doesn't happen anywhere in core.

This is the same as #2 but I changed the comment to be one line like in #5.

Status: Needs review » Needs work

The last submitted patch, 7: 2640178-webform-docblock-fixes-7.patch, failed testing.

fenstrat’s picture

Status: Needs work » Closed (outdated)

Closing to clear out the old Webform 8.x-4.x branch. See #2827845: [roadmap] YAML Form 8.x-1.x to Webform 8.x-5.x.