Problem/Motivation

When administrators edit a profile they see an activate and deactivate button. They should only see "save", as the concept of active and inactive is internal to preserve references.

Proposed resolution

Only show "save" which saves the profile as active. Maybe a "save and make default"?

Remaining tasks

Get 'er done.

User interface changes

Profile types that do not support multiple will only show "save"

Comments

mglaman created an issue. See original summary.

mglaman’s picture

Title: If profile type does not support multiple, do not show "save active" and "save inactive" option » Do not show the option to save as inactive, just save as active.

In the idea of "active" versus "inactive" is to preserve entity reference values, not a state that should be exposed to the end user.

mglaman’s picture

Title: Do not show the option to save as inactive, just save as active. » Do not show the option to save as inactive, just save.

Not even "save as active," just "save" :)

subhojit777’s picture

+1

subhojit777’s picture

Profile types that do not support multiple will only show "save"

Only a save button? Don't you think it will a bit absurd with just a save button and no action.

subhojit777’s picture

Issue tags: +SprintWeekend2016
subhojit777’s picture

Assigned: Unassigned » subhojit777
Status: Active » Needs review
StatusFileSize
new3.97 KB
subhojit777’s picture

Do we need tests as well?

mglaman’s picture

Issue summary: View changes
subhojit777’s picture

StatusFileSize
new5.69 KB

@mglaman This is the test I was talking about in IRC. Can you please what I am missing.

Status: Needs review » Needs work

The last submitted patch, 10: do_not_show_the_option-2639880-10.patch, failed testing.

The last submitted patch, 10: do_not_show_the_option-2639880-10.patch, failed testing.

mglaman’s picture

Status: Needs work » Needs review

Re-running against latest HEAD

Status: Needs review » Needs work

The last submitted patch, 10: do_not_show_the_option-2639880-10.patch, failed testing.

The last submitted patch, 10: do_not_show_the_option-2639880-10.patch, failed testing.

mglaman’s picture

Status: Needs work » Needs review
StatusFileSize
new8.66 KB

Ok, here is a re-vamp that keeps a "Save", "Save Default" and "Delete". The "Save Default" shows/hides based on if current is a default.

Status: Needs review » Needs work

The last submitted patch, 16: do_not_show_the_option-2639880-16.patch, failed testing.

The last submitted patch, 16: do_not_show_the_option-2639880-16.patch, failed testing.

mglaman’s picture

Status: Needs work » Needs review
StatusFileSize
new9.75 KB

I think this is it!

  • mglaman committed 5b48571 on 8.x-1.x
    Issue #2639880 by subhojit777, mglaman: Do not show the option to save...
mglaman’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.