In \Drupal\views\Plugin\views\filter\NumericFilter::valueForm() we add form fields for both value and min/max and then use #states to hide those that don't apply for the currently selected operator.

However, if a child class overrides operators() to provide its own set, which might not contain any operators with min/max (or none with a single value), these fields are still included and, worse, the absence of any #states will leave them always displayed even though they are completely pointless.

While this is easy to fix in the child class, with a short override of the valueForm() method, it would be as easy to fix once and for all in the parent class.

CommentFileSizeAuthor
#21 2637674-21.patch3.15 KBsmustgrave
#21 interdiff-5-21.txt6.11 KBsmustgrave
#5 hide_value_form_fields_based_on_available_operators-2637674-5.patch3.74 KBdrunken monkey
#5 hide_value_form_fields_based_on_available_operators-2637674-5--interdiff.txt2.63 KBdrunken monkey
#2 hide_value_form_fields_based_on_available_operators-2637674-2.patch3.73 KBdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey for Acquia commented
Status: Active » Needs review
FileSize
hide_value_form_fields_based_on_available_operators-2637674-2.patch3.73 KB

The attached patch would implement this.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ for Acquia commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/views/src/Plugin/views/filter/NumericFilter.php
@@ -163,40 +163,44 @@ protected function valueForm(&$form, FormStateInterface $form_state) {
+        // When exposed we drop the value-value and just do value if
+        // the operator is locked.

This can be wrapped closer to 80 cols. But that's the only thing I found with the patch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/views/src/Plugin/views/filter/NumericFilter.php
@@ -163,40 +163,44 @@ protected function valueForm(&$form, FormStateInterface $form_state) {
+    $operators_with_1_value = $this->operatorValues(1);

Can we make this $operators_with_one_value? Same for 2/two below.

Since this changes the form structure, it needs to go into 8.1.x

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey for Acquia commented
Status: Needs work » Needs review
FileSize
hide_value_form_fields_based_on_available_operators-2637674-5--interdiff.txt2.63 KB
hide_value_form_fields_based_on_available_operators-2637674-5.patch3.74 KB

Thanks a lot for reviewing!
Attached is the updated patch with both these objections fixed.

Also thanks for moving this to the right branch!

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
interdiff-5-21.txt6.11 KB
2637674-21.patch3.15 KB

Rerolled for 10.1

Still needs testing.

Status: Needs review » Needs work

The last submitted patch, 21: 2637674-21.patch, failed testing. View results

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.