Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.It's currently too hard to switch the url processor, we should make that easier.
Todo
- make a dummy processor to hold urls
- make a new urlProcessor annotation / plugin type
- use the dummyprocessor to call out to the real url processor (that is set on the facet source)
- add tests
- bikeshed naming
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | make_it_easier_to-2637594-11.patch | 57.03 KB | strykaizer |
| #11 | interdiff.txt | 3.18 KB | strykaizer |
Comments
Comment #2
christianadamski commented1.) The Default URL processor is currently locked, or at least it was a week ago in git.
2.) Taking the core_views_facet as an example, it requires a certain URL processor to work.
Vice versa, the default URL processor won't work there, and the search api facet source won't work with core_views_facets processor.
Comment #3
borisson_This should be the correct way to go, I think.
Comment #4
borisson_Used
git diff -Mthis time; patch is ~half the previous patch's size.Comment #5
borisson_WIP
Comment #6
christianadamski commentedShould I already go ahead and use this patch and align my code to it?
Comment #7
borisson_Not yet, I discussed this a little bit in irc with StryKaizer and we both agree that there will be some big changes still to come in this patch.
Comment #8
borisson_Added more tests. I'm a confident this is a good solution, still needs more work and I'd appreciate a review.
Comment #9
borisson_MOAR TESTS.
Comment #10
borisson_Cleanup
Comment #11
strykaizerTested #10 with custom URL processor, works as expected.
Changed some docblocks and added a bit UI changes, see interdiff.
For me this can go in.
Comment #12
strykaizerOh, we need tests first ofcourse.
For the naming part, I think URL processor handler is fine. There's a nice docblock which explains why that processor exists, and in the UI I just used URL Handler to simplify things.
Comment #13
borisson_Awesome, we might be able to add extra tests afterwards but there is coverage from an integration test + unit tests.
Comment #21
borisson_Is already committed, closing up.