Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel created an issue. See original summary.

swentel’s picture

Status: Active » Needs review
FileSize
3.92 KB

Merely did a search and replace, search at least starts working again

Berdir’s picture

Status: Needs review » Needs work

Tried this, doesn't work for me yet, maybe that's a fault with my custom filters but they don't seem to do much.

I get this error:

Recoverable fatal error: Argument 1 passed to Drupal\search_api_solr\Plugin\search_api\backend\SearchApiSolrBackend::createFilterQueries() must implement interface Drupal\search_api\Query\ConditionGroupInterface, instance of Drupal\search_api\Query\Condition given, called in ...modules/contrib/search_api_solr/src/Plugin/search_api/backend/SearchApiSolrBackend.php on line 1326 and defined in Drupal\search_api_solr\Plugin\search_api\backend\SearchApiSolrBackend->createFilterQueries() (line 1313 ...

It seems to be called repeatedly.. the first time with a condition group and the second time with a Condition..

drunken monkey’s picture

Assigned: Unassigned » drunken monkey
drunken monkey’s picture

Assigned: drunken monkey » Unassigned
Status: Needs work » Needs review
FileSize
10.74 KB
12.34 KB

This one works for me to bring this module up-to-date regarding changes both in the Search API and in Core.

I also created #2645222: Clean up code with some unrelated clean-up.

Berdir’s picture

Awesome.

I've tested this with the updated test and I got a few errors related to facets and specific regression tests (e.g. case stuff) but commented out a few that failed and then got a passing tests, so the basics seem to be working again!

Will commit this with the attached additional test fix.

Berdir’s picture

Status: Needs review » Fixed

  • Berdir committed c717068 on 8.x-1.x authored by drunken monkey
    Issue #2636270 by drunken monkey, swentel, Berdir: Fixed compatibility...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.