http://pareview.sh/pareview/httpgitdrupalorgprojectfblikeboxgit-8x-2x

Initial Patch attached

CommentFileSizeAuthor
#8 2635504-8.patch1.56 KBnaveenvalecha
#5 coding-standards_5.patch917 bytessnehi
coding-standards.patch640 bytesnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Issue tags: +Novice, +Quickfix

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented

initial patch committed.

snehi’s picture

snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commented
Status: Needs work » Needs review
FileSize
coding-standards_5.patch917 bytes

Adding one patch.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs review » Needs work

Thanks! we are near to fix this,
there is also one more left.Can you post coder result as well.
fb_likebox.js: line 7, col 11, Error - Use the function form of "use strict". (strict)

snehi’s picture

snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commented

fb_likebox.js: line 7, col 11, Error - Use the function form of "use strict". (strict)
fb_likebox.js: line 12, col 14, Error - Missing space before function parentheses. (space-before-function-paren)
fb_likebox.js: line 13, col 7, Error - Split 'var' declarations into multiple statements. (one-var)
fb_likebox.js: line 21, col 11, Error - Expected indentation of 8 characters but found 10. (indent)

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs work » Needs review
FileSize
2635504-8.patch1.56 KB
neetu morwani’s picture

neetu morwani CreditAttribution: neetu morwani as a volunteer and at Acquia commented

Above patch looks good. Reviewed.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs review » Fixed

The #8 has been committed.
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.