The project page links to a FitVids jQuery file. Near the top of this file we see two settings:

$.fn.fitVids = function( options ) {
    var settings = {
      customSelector: null,
      ignore: null
    };

Currently, there is the ability to pass in options for customSelector into the FitVid's library, but not the option for ignore.

Plan:
Create a textfield for the admin settings.
Have these options feed into FitVids to utilize the ignore setting.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikedotexe created an issue. See original summary.

mikedotexe’s picture

Patch

mikedotexe’s picture

Issue summary: View changes
mikedotexe’s picture

Issue summary: View changes
Status: Active » Needs review
rahulbile’s picture

Looks good @mikedotexe, attached is the updated patch for passing default value if not set as '', oresle it throws js error of it being null.

Status: Needs review » Needs work

The last submitted patch, 5: ignore-setting-2635066-5.patch, failed testing.

BWPanda’s picture

Works for me...

mikedotexe’s picture

Status: Needs work » Needs review

Looking at some older issues, I think this one never got flipped to "Needs review" so I'm doing that now.

rrrob’s picture

Status: Needs review » Reviewed & tested by the community

#5 looks good and works for me.

NickDickinsonWilde’s picture

Status: Reviewed & tested by the community » Fixed

not promising a 7.x release... but looks good, merged, thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.