The last module that isn't on a stable official release path is field_collection, now that workbench_moderation has been brought back up to date.

Current Makefile

projects[field_collection][version] = 1.x-dev
projects[field_collection][subdir] = contrib
projects[field_collection][download][type] = git
projects[field_collection][download][revision] = ae778f2
projects[field_collection][download][branch] = 7.x-1.x
projects[field_collection][patch][1344672] = http://drupal.org/files/issues/field_collection-et-1344672-187.patch
projects[field_collection][patch][2075325] = http://drupal.org/files/issues/field_collection-field_collection_uuid-2075325-3.patch
projects[field_collection][patch][2298877] = http://drupal.org/files/issues/migration_field_collection-2298877-02.patch

The good news is that our git hash is only four commits away from the 1.0-beta8 tag and there has largely been only bug fix commits till 1.0-beta10.

Proposed Makefile

projects[field_collection][version] = 1.0-beta10
projects[field_collection][subdir] = contrib
projects[field_collection][patch][1344672] = http://drupal.org/files/issues/1344672-489.patch
projects[field_collection][patch][2075325] = http://drupal.org/files/issues/field_collection_uuid-2075325-18.patch
projects[field_collection][patch][2075326] = http://drupal.org/files/issues/field_collection_uuid_services-2075325-18.patch
projects[field_collection][patch][2599248] = http://drupal.org/files/issues/field-collection-2599248-2.patch

Differences

There are no schema changes.

The first patch #1344672 has been updated from #187 to #489 which adds integration with Entity Translation. (Note this issue is still in flux but is nearing completion). The second patch #2075325 has now been split into two to properly add deploy + uuid support field collections. (See the issue for more details) Finally the #2298877 patch was committed to field_collection itself.

Comments

sylus created an issue. See original summary.

sylus’s picture

Issue summary: View changes
sylus’s picture

Title: Updates to Field Collection module. » Updates to Field Collection module + UUID / Deploy
sylus’s picture

Status: Active » Fixed

Tests are all passing on behat specifically related to field_collection one used with beans.

Tested deploy of the 'media' + 'slideshow' type and they now work properly in the deploy workflow.

  • sylus committed 3a1f7af on 7.x-4.x
    Fixed WetKit Deployment for Issue #2634328: Updates to Field Collection...
  • sylus committed d28e869 on 7.x-4.x
    Fixed WetKit Core for Issue #2634328: Updates to Field Collection module...
joseph.olstad’s picture

nice work, so with this update field slideshow and media with translations will now deploy?

sylus’s picture

Yes they will now deploy I've tested both of them under various conditions. Only thing that is out of scope is nested field collections which is a rarity.

joseph.olstad’s picture

ok, we are currently testing a deployment of a media bean. We upgraded to distro dev 4.x dec 13th build
did drush updb

perhaps missing a feature revert.

I'll review some of the overrides but, we get this error message:

Notice: Trying to get property of non-object in panels_mini_block_info() (line 78 of profiles\wetkit\modules\contrib\panels\panels_mini\panels_mini.module).

line 78 and line 79 similar error message.

media bean has no translation >yet<. The file isn't that big, only 15 megs.

we have a ttml caption , added the correct filetype for it, the closed caption works prior to deployment.

using jQuery 1.10

joseph.olstad’s picture

After code review This error probably is occuring because we did not specify an admin title, we left title blank.

I'll edit the bean (media bean) and put a title on and see, it should work this time.

We didn't have this problem prior to update , maybe some extra validation before line 78 would help.

sylus’s picture

I did add this patch in:

#2391073: panels_mini_load & friends need caching

Likely why your getting that warning. I might backtrack that performance improvement if can't track down the error.

joseph.olstad’s picture

ya looks like that patch isn't doing what it should , I'm going to try reversing the patch on panels/mini_panel

joseph.olstad’s picture

ok, we backed off that patch, the error message went away, however the media bean still does not deploy.

Conversion failed when converting the varchar value 'c2ad190a-cd54-4f1a-8efd-e4210b1ff0e6' to data type int.: SELECT revision.[revision_id] AS [revision_id], revision.[vuuid] AS [vuuid], base.[item_id] AS [item_id], base.[field_name] AS [field_name], base.[archived] AS [archived], base.[uuid] AS [uuid], cross_default_revision.cross_sqlsrv AS default_revision FROM field_collection_item base INNER JOIN field_collection_item_revision revision ON revision.revision_id = base.revision_id CROSS APPLY (SELECT CASE WHEN base.revision_id = revision.revision_id THEN 1 ELSE 0 END cross_sqlsrv) cross_default_revision WHERE ( ([base].[item_id] IN (:db_condition_placeholder_0)) ); Array ( [:db_condition_placeholder_0] => c2ad190a-cd54-4f1a-8efd-e4210b1ff0e6 ) in EntityAPIController->query() (line 187 of profiles\wetkit\modules\contrib\entity\includes\entity.controller.inc).

this is a new media bean with translations.

Are there any related settings changes (the shared_content boolean?) or something.

We also disabled the automatic deploy, we're using the deploy queue.

Regular beans are deploying, nodes, files.

we'll try an empty media bean and see.

sylus’s picture

I have only tried with the shared content deploy which sends field collection over first then the bean, likely the queue one isn't smart enough to get the dependency. Should be easy enough to let it know. Also make sure your dest site has field collection uuid services enabled and resources are added. Feature revert should be enough.

joseph.olstad’s picture

Ok, sounds good, I'll look for the feature revert.

joseph.olstad’s picture

our guys prefer to disable shared content deploy, they only want to deploy on queue.

For now we're editing media bean directly on destination.

Thanks for all your hard work on this.

sylus’s picture

Think I got it working in queue now just testing it now.

sylus’s picture

Yeah so I disabled shared_content and tested with just the queue and the field_collection for media worked as expected.

joseph.olstad’s picture

ok, thats good news so there's a new fix for this in a new release? or was this just working for you?

Is there an additional setting we need or is it strictly a patch?

Thanks

sylus’s picture

Nope nothing changed just had time to test with shared_content disabled to absolutely make sure wasn't what was making it work. Once confirmed disabled it worked perfectly with just what is currently committed to dev.

joseph.olstad’s picture

I'll try to retest media deploy in our test environment, with recent code changes to the distro and also configuration changes on our end, (should retest to find out) we had to vastly increase our PDO query size limit (for sqlsrv), the equivalent of the max_allowed_packet_size setting in mysql. BTW, the queue api puts files entirely in the database query, so if you want to deploy rediculously large files you have to increase the max_allowed_packet_size to rediculously high limits. We've increased ours to 384mb so I'm hoping that we can deploy very large files now using the queue api, otherwise with memory processing our php thread limits in dev are even higher at 2 gigs. I'll test the limits of both, I'd like to see how large of a file we can deploy by adjusting the settings.

I'm hoping that maybe this had something to do with the previous test failure with field_collections but not sure. In my tests so far I was able to deploy an empty media field collection that had no translation. I'd like to re-test with a fully translated media bean with first small files (and if that works, then insane large files)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.