So then I am officially requesting "Single Project Promotion"

NAME
-----
check_drupal

DESCRIPTION
-----------
Nagios drupal plugin to monitor the state of a drupal site for security updates, system updates, core errors, core warnings and missing db updates.

PROJECT PAGE
------------
https://www.drupal.org/sandbox/cytopia/2633916

GIT CLONE COMMAND
-------------------
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/cytopia/2633916.git check_drupal

Comments

cytopia created an issue. See original summary.

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxcytopia2633916git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

cytopia’s picture

cytopia CreditAttribution: cytopia commented

I fixed all the errors.
Thanks

cytopia’s picture

cytopia CreditAttribution: cytopia as a volunteer commented
Status: Needs work » Needs review

AUTOMATED PROJECT REVIEW:
--------------------------
http://pareview.sh/pareview/httpgitdrupalorgsandboxcytopia2633916git

adam_’s picture

adam_ CreditAttribution: adam_ as a volunteer commented

This is awesome, looks like a lot of effort went into it.

I'm not sure if PHP is required for the an initial review, but it might? I don't see any PHP in here, but the code looks well organized and thought out.

cytopia’s picture

cytopia CreditAttribution: cytopia as a volunteer commented

Thanks for the review.

Btw how many "this is awesome" does an application need in order to become approved?

adam_’s picture

adam_ CreditAttribution: adam_ as a volunteer commented
Status: Needs review » Needs work

Apologies, I should have offered more constructive feedback.

I've noticed a couple of issues:
1. Your module is missing a .module file, which is preventing it from showing on the module screen to be enabled/disabled.
2. There is no PHP/JS code in here to review and I believe that it is a requirement. From what I understand (and I could be wrong) at least 4-5 functions of PHP/JS. Mainly because this an application for git access and Drupal utilizes those languages. I would recommend coding a admin page or something small in a .module file to meet that requirement.

cytopia’s picture

cytopia CreditAttribution: cytopia as a volunteer commented

Hi hook_awesome

>> 1. Your module is missing a .module file
>> 2. There is no PHP/JS code in here to review

Both is correct and done on purpose.

This is a nagios/icinga monitoring plugin for drupal with the intention to work for every drupal site (D6, D7 and hopefully D8) out of the box without the need to install it as a module.

The intention
Imagine this from a Sysadmin's perspective. Someone who has access to the server, but who can not add code to the project itself.
For example, in my company we are hosting around 30 drupal sites for different customers. We cannot just add modules to their code, but we need to inform them if there are updates available (specifically security updates) or if anything else is wrong with the site.
This can only be achieved by a standalone plugin which does not need to be installed on the site itself.

cytopia’s picture

cytopia CreditAttribution: cytopia as a volunteer commented
Status: Needs work » Needs review
adam_’s picture

adam_ CreditAttribution: adam_ as a volunteer commented

I think I'm getting confused by the core=7.x declaration in the .info file. I see that this is marked as 'other' on the component category so it's not supposed to be a module, apologies.

I've been reading through the documentation to try to find something to help me review the application but I haven't found anything so I've requested a second opinion:
https://groups.drupal.org/node/157669#comment-1137058

cytopia’s picture

cytopia CreditAttribution: cytopia as a volunteer commented

The .info file was just to pass the automated code linting.

Actually currently it is compatible to D6 and D7, for D8 i don't know as I haven't tested it yet.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

I'm not sure that bash scripts are allowed to be hosted in drupal.org projects, I think that is what @hook_awesome is suggesting by PHP being a requirement. Might be better to host this on GitHub or elsewhere if that is indeed a rule...

If you are having scripts in a module you will probably want some way to prevent the scripts from running in a web production environment, meaning some form of .htaccess and/or web.config rules, etc.

joachim’s picture

joachim CreditAttribution: joachim commented

Have you checked for module duplication? I found https://www.drupal.org/project/nagios.

cytopia’s picture

cytopia CreditAttribution: cytopia as a volunteer commented

@Joachim: This is different as the code I have written works for drupal multisites and does not require to be installed into Drupal itself. The code I am providing is fully independent. Also my version supports SSH and NRPE for secure communication whereas the one you mentioned only supports NRPE (and http(s) for insecure comm).

@Ryan Weal: Please see the discussed solution here: https://groups.drupal.org/node/157669#comment-1137073

cytopia’s picture

cytopia CreditAttribution: cytopia as a volunteer commented

Hi guys,
please let me know if this will be approved or whether I should remove it.

adam_’s picture

adam_ CreditAttribution: adam_ as a volunteer commented

I think that the resolution in another thread has been to request Single Project Promotion. I also think that request has to be made in this (the application) thread. The application process is pretty slow and I know it's frustrating, but hang in there! You can speed up your application by getting a PAReview Bonus (https://www.drupal.org/node/1975228). The bonus is supposed to speed your project application through the queue.

cytopia’s picture

cytopia CreditAttribution: cytopia as a volunteer commented

So then I am officially requesting "Single Project Promotion"

For the PAReview Bonus: That's pretty much nonsense in my eyes. How would I be able to approve other people's project if I haven't been approved myself. Looks like this is how it works here, but it does not make any sense to me.

Best wishes

cytopia’s picture

cytopia CreditAttribution: cytopia as a volunteer commented
Issue summary: View changes
davidam’s picture

davidam CreditAttribution: davidam commented

You could use the drupal wiki to promote your source. Here is a little mess, isn't it?

cytopia’s picture

cytopia CreditAttribution: cytopia commented

Could someone accept or reject please.

cytopia’s picture

cytopia CreditAttribution: cytopia commented

ping...
Anyone here who can decide to accept or reject?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

> How would I be able to approve other people's project if I haven't been approved myself.

We're all coders in the project applications queue. You have domain knowledge of things you have built before. When enough people have given positive feedback on something that is when it typically gets approved. While my application was under review I was also encouraged to review other people's work. So I did... I made comments on things I knew about at the time.

There is no committee reviewing your work and no score card behind the scenes. Just the comments here. The tough part, in my opinion, is getting attention to your issues and getting people to understand who you are, what you know, etc. It also helps to find a reviewer that is passionate about the same type of code.

If you're interested in getting things moving I suggest hanging out in the IRC channels and/or going to meetups. Join the discussions about improving the application process. Contribute in noticeable and beneficial ways. If you can attend a sprint those are great times to connect on these issues because often people with the powers to make change are in the same room. Sprints are really where things get done.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle at Hannemyr Nye Medier AS commented
Status: Needs review » Needs work

This application doesn't really fit the PAreview format.

For starters, it is not a Drupal module or theme.

In #11, it says: "The .info file was just to pass the automated code linting."

The automated code linting checks PHP and JavaScript. This project is made up of two Gnu/Linux shell scripts, so there is almost nothing for PAReview.sh to review (however, it is very passionate about line lengths, so it complains about too long lines is your README and CHANGELOG).

Since this project is not Drupal module or theme, the .info-file is simply wrong and should be removed from the project. As long as this misleading file is in the repo, it cannot pass manual review.

Why is the default branch set to 7.x-1.x? Since the shell-scripts are not tied to a specific Drupal version, this is misleading as well. I think its default branch for this particular project should be "master".

This project also does not meet the checks listed on the PAreview template, so it clearly needs work:

3rd party code: The applicant is "cytopia". The author of one of shell-scripts that make up the project is "Patrick Plocke". Is "cytopia" an alias for "Patrick Plocke"? This must be made clear. If it is not your own code, it must be removed.

Licensing: The script is licensed under MIT. To have your repo on Drupal.org, you must license it under GPLv2 and later.

To me, it looks as a project that really belongs on GitHub (i.e. not on Drupal.org), but I leave that particular call to a d.o. Git admin.

However, if you want it considered for hosting here, you need to remove the misleading .info-file, and get the 3rd party code/licensing issues sorted out.

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.