When a user is removed from the system, no acceptance documents are removed from the database. So in a rare case when a new user with the same email address is recreated, entity legal fails to enforce acceptance, as it finds existing documents. This happens even though the user's uid is different.

The patch I am attaching introduces hook_user_delete() which removes all entities when a user is deleted.

CommentFileSizeAuthor
#3 2633040-3.patch2.18 KBclaudiu.cristea
#2 2633040-2.test-only.patch1.2 KBclaudiu.cristea
entity_legal.patch935 bytesivrh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drupal-developers-melbourne created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Version: 7.x-1.5 » 8.x-2.x-dev
FileSize
2633040-2.test-only.patch1.2 KB

Moving to 8.x-2.x. Proving the bug.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
2633040-3.patch2.18 KB

And the fix.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Assigned: ivrh » Unassigned

The last submitted patch, 2: 2633040-2.test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Title: No documents acceptance deleted when user is deleted » Acceptance records not deleted on user removal
idimopoulos’s picture

idimopoulos CreditAttribution: idimopoulos at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Reviewed & tested by the community

Works as expected and is necessary for cleaning up the database.

  • claudiu.cristea committed 25ec626 on 8.x-2.x 
    Issue #2633040 by claudiu.cristea, ivrh, idimopoulos: Acceptance records...
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented

Fixing credits.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.