Add composer.json to module [#2632950]

Problem/Motivation

There is no composer.json file found in module.
Please see https://www.drupal.org/node/2514612

Proposed resolution

Add the composer.json file.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#17	2632950-8.patch	681 bytes	splash112
#17	8.x-4.x: PHP 7.2 & MySQL 5.5, D8.8 161 pass PHP 5.5 & MySQL 5.5, D8.7 161 pass PHP 7.3 & MySQL 5.5, D8.8.1 161 pass
#16	2632950-7.patch	681 bytes	splash112
#16	8.x-4.x: PHP 7.2 & MySQL 5.5, D8.8 Ancillary require failure
#15	2632950-5.patch	685 bytes	splash112
#15	8.x-4.x: PHP 7.2 & MySQL 5.5, D8.8 Ancillary require failure
#13	2632950-4.patch	674 bytes	splash112
#13	8.x-4.x: PHP 7.2 & MySQL 5.5, D8.8 141 pass, 40 fail
#12	2632950-12-add-composer-json-to-module.patch	1.87 KB	MilosR
#12	8.x-4.x: PHP 7.2 & MySQL 5.5, D8.7 Composer require failure PHP 7.3 & MySQL 5.5, D8.8.1 Composer require failure
#10	2632950-10-add-composer-json-to-module.patch	1.84 KB	MilosR
#10	8.x-4.x: PHP 7.2 & MySQL 5.5, D8.7 Build Successful PHP 7.3 & MySQL 5.5, D8.8 Build Successful
#8	2632950-3.patch	736 bytes	splash112
#8	8.x-4.x: PHP 7.2 & MySQL 5.5, D8.8 141 pass, 40 fail PHP 7.2 & MySQL 5.5, D8.9 141 pass, 40 fail PHP 7.3 & MySQL 5.5, D8.8.1 141 pass, 40 fail
#6	2632950-2.patch	703 bytes	splash112
#6	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.7 141 pass, 25 fail PHP 7.2 & MySQL 5.5, D8.8 141 pass, 40 fail PHP 7.2 & MySQL 5.5, D8.9 141 pass, 40 fail
#2	2632950-1.patch	1021 bytes	rakesh.gectcr
#2	8.x-4.x: PHP 5.5 & MySQL 5.5 159 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

11 December 2015 at 00:37

rakesh.gectcr created an issue. See original summary.

Comment #2

rakesh.gectcr

he/him

Malayalam

Manchester

CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented 11 December 2015 at 00:40

Status:

Active

» Needs review

File	Size
2632950-1.patch	1021 bytes
8.x-4.x: PHP 5.5 & MySQL 5.5 159 pass

Comment #3

TR CreditAttribution: TR commented 11 December 2015 at 03:12

I'd rather not. We don't have any external dependencies that require composer, and hopefully we won't in the future either.

Comment #4

TR CreditAttribution: TR commented 11 December 2015 at 03:27

Status:

Needs review

» Needs work

Also, you don't list the individual Ubercart modules, there's no newline at the end of the file, and IMO authors shouldn't be in there.

Comment #5

TR CreditAttribution: TR commented 2 April 2016 at 03:41

Status:

Needs work

» Closed (won't fix)

Comment #6

splash112 CreditAttribution: splash112 commented 3 March 2020 at 17:20

Status:

Closed (won't fix)

» Active

File	Size
2632950-2.patch	703 bytes
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.7 141 pass, 25 fail PHP 7.2 & MySQL 5.5, D8.8 141 pass, 40 fail PHP 7.2 & MySQL 5.5, D8.9 141 pass, 40 fail

Seems Drupal moved to use composer more and more. Maybe a moment to reconsider?
Attached a clean patch, sadly I could not figure out a way to test if it actually worked as designed.

Comment #7

TR CreditAttribution: TR commented 3 March 2020 at 18:52

Status:

Active

» Needs work

Tests fail.

Comment #8

splash112 CreditAttribution: splash112 commented 4 March 2020 at 05:06

File	Size
2632950-3.patch	736 bytes
8.x-4.x: PHP 7.2 & MySQL 5.5, D8.8 141 pass, 40 fail PHP 7.2 & MySQL 5.5, D8.9 141 pass, 40 fail PHP 7.3 & MySQL 5.5, D8.8.1 141 pass, 40 fail

Thanks, trying again. Trying to easy back into development...

Comment #9

splash112 CreditAttribution: splash112 commented 4 March 2020 at 07:28

seems this was not as easy as I might have thought...

Comment #10

MilosR CreditAttribution: MilosR at Websolutions Agency commented 4 March 2020 at 09:43

File	Size
2632950-10-add-composer-json-to-module.patch	1.84 KB
8.x-4.x: PHP 7.2 & MySQL 5.5, D8.7 Build Successful PHP 7.3 & MySQL 5.5, D8.8 Build Successful

Comment #11

splash112 CreditAttribution: splash112 commented 4 March 2020 at 11:45

That misses the Rules dependency?

File	Size
2632950-12-add-composer-json-to-module.patch	1.87 KB
8.x-4.x: PHP 7.2 & MySQL 5.5, D8.7 Composer require failure PHP 7.3 & MySQL 5.5, D8.8.1 Composer require failure

Comment #13

splash112 CreditAttribution: splash112 commented 4 March 2020 at 16:37

File	Size
2632950-4.patch	674 bytes
8.x-4.x: PHP 7.2 & MySQL 5.5, D8.8 141 pass, 40 fail

Trying without the require-dev. Might be that the tests have already some rules integration that messed up things before?
@MilosR your version seems to be requiring the release version of some Ubercart module while tests are done against dev?

Comment #14

TR CreditAttribution: TR commented 4 March 2020 at 17:49

The tests currently run green without the composer.json patch - the reason they're failing is because the proposed composer.json does not specify the same dependencies as the working .info.yml files.

uc_order is the only module that requires Rules, and it requires the current -dev version of Rules:
uc_order/uc_order.info.yml: - rules:rules (>8.x-3.x-alpha5)