Allow disabling of "move JS to footer" on specific pages

Looking more closely at the code, another idea would be to make the values in $all_in_footer_list (or something similar to it) accessible through a textarea. This would allow developers to enter a path such as "/sites/all/modules/calendar/js/calendar_overlap.js" to not be moved to the footer.

Thanks for the alter code, certainly makes sense to handle it that way. We will give it a try.

Was also asking if it might be worthwhile to provide an option in the user interface for developers. Possibly leverage the "per file settings" code used on the JS compression page, and allow devs to select which JS files will cause core files to not be put in the footer?

Thank you, I was not suggesting it is a simple task. I was merely offering the 'per file settings' functionality as a representative example, and asking if you felt it would be worthwhile functionality to add. You have a much better sense of what features might be valued by those who use the module than I do.

Thanks for the feedback and we'll give the hook a try shortly.

We have tested the hook in #3 and looks like it does the job. Thank you very much!

Do you think it would it be of value to add the hook to advagg.api.php with an example for others?

On closer examination, I think I spoke too soon. Looks like the cache was not fully cleared when I last checked, and the suggested hook doesn't impact the result. I'm only able to see calendar days if I disable moving JavaScript to the footer.

See attached images.

Was looking at the calendar-day-overlap.tpl.php template, and it has inline jQuery to hide the container while the page is rendering. This seems to be the issue, since #single-day-container is being loaded with content, but has CSS of "visibility:hidden".

What's the proper way to handle inline JS from other modules with AdvAgg?

http://cgit.drupalcode.org/calendar/tree/theme/calendar-day-overlap.tpl....
http://cgit.drupalcode.org/calendar/tree/theme/calendar-day-overlap.tpl....

  <?php if (!empty($scroll_content)): ?>
  <script>
    try {
      // Hide container while it renders...  Degrade w/o javascript support
      jQuery('#single-day-container').css('visibility','hidden');
    }catch(e){ 
      // swallow 
    }
  </script>
  <?php endif; ?>

<?php if (!empty($scroll_content)): ?>
<script>
try {
  // Size and position the viewport inline so there are no delays
  calendar_resizeViewport(jQuery);
  calendar_scrollToFirst(jQuery);
  jQuery('#single-day-container').css('visibility','visible');
}catch(e){ 
  // swallow 
}
</script>
<?php endif; ?>

Thanks for the suggestions, still got the same results.

Would you recommend the best way to fix this would be by patching Calendar?

It seems as though they do. This is the code at the start of #single-day-container:

<div id="single-day-container">
    <script>
function advagg_mod_1() {
  // Count how many times this function is called.
  advagg_mod_1.count = ++advagg_mod_1.count || 1;
  try {
    if (advagg_mod_1.count <= 40) {
      
    try {
  	  // Hide container while it renders...  Degrade w/o javascript support
      jQuery('#single-day-container').css('visibility','hidden');
    }catch(e){ 
      // swallow 
    }
  

      // Set this to 100 so that this function only runs once.
      advagg_mod_1.count = 100;
    }
  }
  catch(e) {
    if (advagg_mod_1.count >= 40) {
      // Throw the exception if this still fails after running 40 times.
      throw e;
    }
    else {
      // Try again in 250 ms.
      window.setTimeout(advagg_mod_1, 250);
    }
  }
}
function advagg_mod_1_check() {
  if (window.jQuery && window.Drupal && window.Drupal.settings) {
    advagg_mod_1();
  }
  else {
    window.setTimeout(advagg_mod_1_check, 250);
  }
}
advagg_mod_1_check();</script>

And this is the code immediately after the "single-day-footer" at the end of the content section:

<script>
function advagg_mod_2() {
  // Count how many times this function is called.
  advagg_mod_2.count = ++advagg_mod_2.count || 1;
  try {
    if (advagg_mod_2.count <= 40) {
      
try {
  // Size and position the viewport inline so there are no delays
  calendar_resizeViewport(jQuery);
  calendar_scrollToFirst(jQuery);
  jQuery('#single-day-container').css('visibility','visible');
}catch(e){ 
  // swallow 
}


      // Set this to 100 so that this function only runs once.
      advagg_mod_2.count = 100;
    }
  }
  catch(e) {
    if (advagg_mod_2.count >= 40) {
      // Throw the exception if this still fails after running 40 times.
      throw e;
    }
    else {
      // Try again in 250 ms.
      window.setTimeout(advagg_mod_2, 250);
    }
  }
}
function advagg_mod_2_check() {
  if (window.jQuery && window.Drupal && window.Drupal.settings) {
    advagg_mod_2();
  }
  else {
    window.setTimeout(advagg_mod_2_check, 250);
  }
}
advagg_mod_2_check();</script></div>

Are there issues or patches for maps you can point me to so I can create a Calendar module patch? Thanks.

Nick, thanks for the patch. I don't have time at the moment to review, but most likely I will next week.

Regarding "just working" out of the box with the Calendar module, it would be the calendar/week and calendar/day paths. However, I'm not sure if it's best to add this by default, or provide some guidance in the module notes.

If the Calendar module owners update the JS in the future, there could be a situation where the paths don't need to be included. Also, if a Drupal developer chooses not to use the default Overlap functionality, we would be skipping AdvAgg's capabilities on a page where it could be enabled. Another potential issue is if a developer changes the path of their calendar views, and doesn't realize AdvAgg has hard-coded calendar paths.

@mikeytown, thanks for these patches. I finally had a chance to test and was able to get it to work successfully.

I was setting both the $move_js_to_footer and $defer_setting values in the user interface, so I had to add $lists[8] = 0; to the function too. Worked just as I would expect.