CommentFileSizeAuthor
#5 2631326.5.flagListRegression.patch2.4 KBsocketwench
#3 2631326.3.flagListRegression.patch2.25 KBsocketwench
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim CreditAttribution: joachim commented
Priority: Normal » Major

Upping. This is a total pain when you have flags on different entity types.

socketwench’s picture

socketwench CreditAttribution: socketwench as a volunteer commented
Status: Active » Needs review
FileSize
2631326.3.flagListRegression.patch2.25 KB

Includes a minor, unrelated doc fix.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Needs work

Thanks for the patch!

Slight difference from 3.x: when a flag has no bundles selected, 3.x shows just '-'. Which admittedly isn't very clear, but I'm not sure that using getApplicableBundles() is right. As an admin, I'd rather see 'All' and know that I don't need to edit that flag to account for a new bundle.

socketwench’s picture

socketwench CreditAttribution: socketwench as a volunteer commented
Status: Needs work » Needs review
FileSize
2631326.5.flagListRegression.patch2.4 KB

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Fixed! Thanks for the patch :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.