The Context Datalayer module provides the ability to modify the dataLayer global Javascript variable created by the datalayer module using Context for Drupal, and the ability to base a Context condition on dataLayer values.

Sandbox

https://www.drupal.org/sandbox/bighappyface/2505541

Git Clone Command

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/bighappyface/2505541.git context_datalayer

Comments

bighappyface created an issue. See original summary.

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxbighappyface2505541git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

bighappyface’s picture

Issue summary: View changes
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

bighappyface’s picture

Status: Closed (won't fix) » Needs review
3ssom’s picture

Status: Needs review » Needs work

You Project looks good .. except for one suggestion you find below :)

Automated Review

the automated review found some errors here:
http://pareview.sh/pareview/httpgitdrupalorgsandboxbighappyface2505541git

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[Yes: Follows] the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
[Yes: Meets the security requirements.]
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
recommendation:
  1. (+) Implements hook_help().

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

klausi’s picture

Status: Needs work » Needs review

A missing hook_help() is not an application blocker, anything else that you found or should this be RTBC instead?

bighappyface’s picture

Status: Needs review » Reviewed & tested by the community

@3ssom thanks for the review!

@klausi thanks for the follow up and guidance!

Because this module augments the context condition/reaction sets it feels like hook_help may be unnecessary and does not follow precedent for similar modules:

https://www.drupal.org/project/context_disable_context
https://www.drupal.org/project/path_entity_context
https://www.drupal.org/project/context_feeds
https://www.drupal.org/project/context_meta

The last one, context_meta, seems like a particularly good example as it actually implements menu hooks for routes that should have an associated help entry.

Under the guidance per @klausi I am going to move into RTBC. Please set it back to another status if there are any objections, and thanks again!

bighappyface’s picture

Status: Reviewed & tested by the community » Needs review

Moving back to "Needs Review" per the "What to expect" instructions guidance that the reviewer makes the RBTC status change.

rgristroph’s picture

I have read through this and no problems jumped out at me. I'm going to actually run it on a test site and do more complete trial, I'll comment further with the results.

bighappyface’s picture

@rgristroph any updates?

3ssom’s picture

Status: Needs review » Reviewed & tested by the community

Hello bighappyface,

Sorry for this late follow up .. I see no blocker as kluasi pointed regrading my review above ..

I think this a RTBC!

Thank you

apaderno’s picture

Assigned: Unassigned » apaderno
Status: Reviewed & tested by the community » Fixed

I will update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.