Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The Context Datalayer module provides the ability to modify the dataLayer
global Javascript variable created by the datalayer module using Context for Drupal, and the ability to base a Context condition on dataLayer
values.
Sandbox
https://www.drupal.org/sandbox/bighappyface/2505541
Git Clone Command
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/bighappyface/2505541.git context_datalayer
Comments
Comment #2
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxbighappyface2505541git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
bighappyface CreditAttribution: bighappyface at Rackspace for Rackspace commentedComment #4
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5
bighappyface CreditAttribution: bighappyface at Rackspace for Rackspace commentedComment #6
3ssom CreditAttribution: 3ssom commentedYou Project looks good .. except for one suggestion you find below :)
Automated Review
the automated review found some errors here:
http://pareview.sh/pareview/httpgitdrupalorgsandboxbighappyface2505541git
Manual Review
recommendation:
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #7
klausiA missing hook_help() is not an application blocker, anything else that you found or should this be RTBC instead?
Comment #8
bighappyface CreditAttribution: bighappyface at Rackspace for Rackspace commented@3ssom thanks for the review!
@klausi thanks for the follow up and guidance!
Because this module augments the context condition/reaction sets it feels like
hook_help
may be unnecessary and does not follow precedent for similar modules:https://www.drupal.org/project/context_disable_context
https://www.drupal.org/project/path_entity_context
https://www.drupal.org/project/context_feeds
https://www.drupal.org/project/context_meta
The last one,
context_meta
, seems like a particularly good example as it actually implements menu hooks for routes that should have an associated help entry.Under the guidance per @klausi I am going to move into RTBC. Please set it back to another status if there are any objections, and thanks again!
Comment #9
bighappyface CreditAttribution: bighappyface at Rackspace for Rackspace commentedMoving back to "Needs Review" per the "What to expect" instructions guidance that the reviewer makes the RBTC status change.
Comment #10
rgristroph CreditAttribution: rgristroph commentedI have read through this and no problems jumped out at me. I'm going to actually run it on a test site and do more complete trial, I'll comment further with the results.
Comment #11
bighappyface CreditAttribution: bighappyface at Rackspace for Rackspace commented@rgristroph any updates?
Comment #12
3ssom CreditAttribution: 3ssom commentedHello bighappyface,
Sorry for this late follow up .. I see no blocker as kluasi pointed regrading my review above ..
I think this a RTBC!
Thank you
Comment #13
apadernoI will update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks go the dedicated reviewer(s) as well.