Unnecessary CSS added to every page request [#2630480]

The ldap_user.css and ldap_servers.admin.css are added to every page request, which is undesired as they are not actually *used* on every page request, but only on certain pages.

ldap_user.css should only be added when the field widget is viewed, so that can be moved to ldap_user_field_widget_form()
ldap_servers.admin.css should only be added if the current page starts with admin/config/people/ldap/servers.

Comment	File	Size	Author
#2	2630480-clean-css-additions.patch	2.15 KB	Dave Reid
#2	7.x-2.x: PHP 5.4 & MySQL 5.5, D7 21 pass PHP 5.5 & MySQL 5.5, D7 21 pass PHP 5.6 & MySQL 5.5, D7 21 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

7 December 2015 at 19:03

Dave Reid created an issue. See original summary.

Comment #2

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid at Lullabot commented 7 December 2015 at 19:04

Status:

Active

» Needs review

File	Size
2630480-clean-css-additions.patch	2.15 KB
7.x-2.x: PHP 5.4 & MySQL 5.5, D7 21 pass PHP 5.5 & MySQL 5.5, D7 21 pass PHP 5.6 & MySQL 5.5, D7 21 pass

Comment #3

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 11 February 2017 at 19:02

Status:

Needs review

» Needs work

Comment #4

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 11 February 2017 at 19:02

Status:

Needs work

» Needs review

Comment #5

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 12 July 2017 at 17:40

Hi Dave

Thanks for your patch, I know this is really old but could you tell me why you removed the following CSS?

-  
-form#dblog-filter-form div#edit-type-wrapper,
-table#admin-dblog th img
-{ display: none;}
-code.export-summary {font-weight: normal;}
-
-table#admin-dblog th a,
-table#admin-dblog th {text-decoration: none; color: #000000;}
-th code {}

The id attributes look like they'd only apply to dblog but then again I found include_once references to 'dblog.admin.inc' in ldap_help and ldap_authorization.

Comment #6

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 2 October 2017 at 17:49

Status:

Needs review

» Postponed (maintainer needs more info)

Comment #7

5 December 2017 at 19:02

grahl committed 0419abe on 7.x-2.x authored by Dave Reid

Issue #2630480 by Dave Reid, grahl: Unnecessary CSS added to every page...

Comment #8

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 5 December 2017 at 19:03

Status:

Postponed (maintainer needs more info)

» Fixed

The css in ldap_servers.admin.css is used inconsistently throughout the admin pages so I loosened the check in init() and left some notes. I actually think that most of that CSS doesn't do anything but leaving it as-is, if someone currently expects that to be there. It's gone in 8 anyway.