Problem/Motivation

A new version of MinkPhantomJSDriver was released a few days ago. Its a good time to get rid of our "dev-master" composer requirement and use a tagged release instead.

The current composer requirement breaks sites which use composer manager (http://kopy.io/MMZBU). We run into problem 3 (https://getcomposer.org/doc/faqs/should-i-commit-the-dependencies-in-my-...) because we commit our vendor directory.

Proposed resolution

Update mink-phantomjs-driver 0.3.1

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2629772-2.patch11.52 KBwebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

Status: Active » Needs review
Issue tags: +Composer
FileSize
11.52 KB
webflo’s picture

Issue summary: View changes
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Thank you!

skyredwang’s picture

I tried to apply the patch to 8.0.1, but I got

# git apply -v 2629772-2.patch 
Checking patch composer.lock...
Checking patch core/composer.json...
Checking patch vendor/composer/ClassLoader.php...
Checking patch vendor/composer/autoload_files.php...
Checking patch vendor/composer/autoload_real.php...
Checking patch vendor/composer/installed.json...
error: while searching for:
        ]
    },
    {
        "name": "jcalderonzumba/mink-phantomjs-driver",
        "version": "dev-master",
        "version_normalized": "9999999-dev",
        "source": {
            "type": "git",
            "url": "https://github.com/jcalderonzumba/MinkPhantomJSDriver.git",
            "reference": "10d7c48c9a4129463052321b52450d98983c4332"
        },
        "dist": {
            "type": "zip",
            "url": "https://api.github.com/repos/jcalderonzumba/MinkPhantomJSDriver/zipball/10d7c48c9a4129463052321b52450d98983c4332",
            "reference": "10d7c48c9a4129463052321b52450d98983c4332",
            "shasum": ""
        },
        "require": {
            "behat/mink": "~1.6",
            "jcalderonzumba/gastonjs": "~1.0",
            "php": ">=5.4",
            "twig/twig": "~1.8"
        },
        "require-dev": {
            "phpunit/phpunit": "~4.6",
            "silex/silex": "~1.2",
            "symfony/css-selector": "~2.1",
            "symfony/phpunit-bridge": "~2.7",
            "symfony/process": "~2.3"
        },
        "time": "2015-10-05 18:24:44",
        "type": "mink-driver",
        "extra": {
            "branch-alias": {
                "dev-master": "0.4.x-dev"
            }
        },
        "installation-source": "source",
        "autoload": {
            "psr-4": {
                "Zumba\\Mink\\Driver\\": "src"
            }
        },
        "notification-url": "https://packagist.org/downloads/",
        "license": [
            "MIT"
        ],
        "authors": [
            {
                "name": "Juan Francisco Calderón Zumba",
                "email": "juanfcz@gmail.com",
                "homepage": "http://github.com/jcalderonzumba"
            }
        ],
        "description": "PhantomJS driver for Mink framework",
        "homepage": "http://mink.behat.org/",
        "keywords": [
            "ajax",
            "browser",
            "headless",
            "javascript",
            "phantomjs",
            "testing"
        ]
    },
    {
        "name": "symfony/class-loader",
        "version": "v2.7.6",
        "version_normalized": "2.7.6.0",

error: patch failed: vendor/composer/installed.json:2736
error: vendor/composer/installed.json: patch does not apply
Checking patch vendor/jcalderonzumba/mink-phantomjs-driver/.gitignore...
Checking patch vendor/jcalderonzumba/mink-phantomjs-driver/bin/run-tests.sh...
Checking patch vendor/jcalderonzumba/mink-phantomjs-driver/composer.json...

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 3e4354c and pushed to 8.0.x. Thanks!

  • alexpott committed 96808b3 on 8.1.x
    Issue #2629772 by webflo: Update mink-phantomjs-driver to a tagged...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Anonymous’s picture

@alexpott

> I tried to apply the patch to 8.0.1, but I got

Is there a patch version that applies cleanly to 8.0.1?

EDIT: solved in 8.0.2.

userofdrupal’s picture

I'm trying to upgrade Drupal from 8.0.1 to 8.0.2.
I originally setup drupal via:

composer create-project drupal/drupal mysite 8.0.*

When I run composer update from my Drupal root directory, it gives the following error:

[RuntimeException]
The .git directory is missing from /home/someuser/mysite/vendor/jcalderonzumba/mink-phantomjs-driver, see https://getcomposer.org
/commit-deps for more information

So how do I fix this/upgrade to 8.0.2?

bojanz’s picture

@userofdrupal
Remove vendor/jcalderonzumba/mink-phantomjs-driver, then rerun composer update.

sushantverma.it’s picture

Below are the steps to resolve the issue.

  • Rebuild the composer.json by command:- composer drupal-rebuild
  • Update dependencies by command:- composer drupal-update
  • Activate address module :- drush en address

The above steps enable the "address" module after 2days work. Hope helps other too.

Lukas von Blarer’s picture

I guess this issue will fix this: #2652142: composer drupal-update fails on jcalderonzumba/gastonjs

The important part is that you need to delete vendor/jcalderonzumba/gastonjs before you run composer drupal-update