I'm going to tag a new release.

Comments

Kristen Pol created an issue. See original summary.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Title: Make 8.0.1 release to make core » Make 8.0.1 release to match core
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Active » Postponed (maintainer needs more info)

Actually... maybe we can't do patch level releases on contrib projects?

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Postponed (maintainer needs more info) » Postponed

Ok... this hasn't landed yet:

#1612910: [policy, no patch] Switch to Semantic Versioning for Drupal contrib extensions (modules, themes, etc)

so marking this postponed.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Status: Postponed » Needs review

The latest released core version is 8.0.1. It doesn't matter if the policy for tag naming will change. It is OK for us to pin the demo to the most recent tag, no matter what the naming convention is, right?

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Status: Needs review » Postponed (maintainer needs more info)

whoops, misunderstood. I thought this was https://www.drupal.org/node/2629510. Sorry.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

We can do a 8.x-1.1. Last I looked at #1612910: [policy, no patch] Switch to Semantic Versioning for Drupal contrib extensions (modules, themes, etc) it was not clear if contribs will support semantic versioning anytime soon.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Postponed (maintainer needs more info) » Needs review

Ok... so my thought is to match core like:

Thoughts?

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Title: Make 8.0.1 release to match core » Make release to match core
loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

I edited this comment because I was being dumb.

Sounds right, KP :)

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

I edited the comment I wrote above and deleted an idea I had. Perhaps I shouldn't have. I think if we are going to have release names that match core, then we should use:

  • 8.x-1.[n] = D8 Core 8.0.x-dev , D8 Core 8.1.x-dev
  • 8.x-2.[n] = D8 Core 8.2.x-dev
  • 8.x-3.[n] = D8 Core 8.3.x-dev

Eh?

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

That could work too. I don't have a strong opinion. We can leave this here and see if anyone else chimes in.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

There is no more 8.0.x, 8.1 is stable now and 8.2 is in development. I think its fine for the demo to track the latest stable version, then we don't need to have all those branches. When 8.1 goes unsupported and 8.2 goes stable, we can switch there? Sounds like less maintenance required to me :)

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

So, in other words:

While core is stable on 8.1:
* Our dev branch stays as is: 8.x-1.x-dev.
* Releases: 8.x-1.0, 8.x-1.1, etc.
When core stable switches to 8.2:
* We'll create a new dev branch: 8.x-2.x-dev
* Releases: 8.x-2.0, 8.x-2.1, etc.

Right? :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Yeah that is fine IMHO.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

Ok, based on #14, then our current release would be 8.x-1.2 (projects[drupal][version] = 8.1.2) which is based off of 8.x-1.x-dev.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Title: Make release to match core » Discussion on how to make release to match core in some way
loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

#16 sounds right to me except that we are on 8.1.3 now :)

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

Git is in a funky state. I had created 8.x-1.3 and pushed it up before I realized we were still on 8.x-1.2 so then I deleted 8.x-1.3. Then I created it again and pushed the tag up but it's still not show up on:

https://www.drupal.org/node/add/project-release/2267517

Yet when I do:

git ls-remote --tags

they show up:

[mac:kristen:multilingual_demo]$ git ls-remote --tags
From kepol@git.drupal.org:project/multilingual_demo.git
c4c49dd218f569300cbb2b2160a21bbb3092130e	refs/tags/8.x-1.0
e625263e7f722ec551e57c550b50e46ab733fd52	refs/tags/8.x-1.3

Any ideas how to get the reincarnated 8.x-1.3 tag to show up on d.o?

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

"Any ideas how to get the reincarnated 8.x-1.3 tag to show up on d.o?"
The tag looks right to me. I'd give it a day. I've seen two other things that haven't shown up on d.o. today and they also seemed like a caching or queue issue. Perhaps there is some infrastructure problem.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

Perhaps the system is expecting an 8.x-1.1 tag. We could create an 8.x-1.1 and 8.x-1.2 tag as well and see if that triggers anything.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

In #21 I wrote, "We could create an 8.x-1.1 and 8.x-1.2 tag". We could base the tags off the commits when we updated core(afc3ac and 1fda74). Might be a good idea anyway. I don't see the new tag showing up on the project page yet. Do you all mind if I make those tags and see if it helps?

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

You are welcome to add those others but my guess is it won't help. When I first created the 1.3 tag it did show up on d.o. But after I deleted and recreated it didn't show up.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

OK, based on #23, I think we should just wait until 8.1.4 core is released before we cut a new tag for this project.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Needs review » Fixed

Ok, then let's do that when the 8.1.4 update happens. Marking this fixed since we sorted out a process. Thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Fully agreed with the outcome of this issue. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.