Pager fix causes performance and memory regression

In views_php.module, views_php_views_post_build($view) kills the limit/offset in the query and will return all rows thus increasing the page load time.

In my case, it craps out after all memory is consumed by I have a view with 72 pages of 50 items each. The crazy thing is that I don't even have views_php filtering defined for this view. Yes, it kills the query's range even if you just have views_php fields!

Furthermore, I still lose the pager because of

$this->wrapped->total_items = count($this->wrapped->view->result);

and

$this->wrapped->view->result = array_slice($this->wrapped->view->result, $offset, $item_per_page);

int views_php_plugin_pager.inc function updated_wrapped_pager()

PS. I'm on 7.x-2.x-dev but they closed both of the issues on the branch as duplicates of the 7.x-1.x-dev issue

Hi everyone,

Just to confirm we were hitting the memory issues with the latest release of Views PHP and Search API on Drupal 7:

Search API: 7.x-1.25
Views PHP: 7.x-1.0-alpha3

These latest releases had fully fixed pagers and counts, so we encountered no issues with those at all, but unfortunately, on a site with tens of thousands of nodes indexed, the search pages rapidly became unusable with the internal memory / page limits not being respected.

After trying various combinations of modules and patches, we found the following worked perfectly, patch #1937364-1: Filter does not respect pagination, it runs through all nodes in a search run on the alpha 1 release of Views PHP:
https://www.drupal.org/project/views_php/releases/7.x-1.0-alpha1

This is working perfectly (so far) with the latest Search API modules, so may be useful for anyone else hitting this potentially quite popular edge case.

All the best,
James

As pointed out previously the cause of performance degradation is that module forces view to load all items not respecting pagers' settings. It surely needed for sorting and filtering but simple field output is not the case. So, i suggest to enable loading of all items only when it's needed - in filter/sort handlers and fields' click-sort. Here is a patch - works great for me.

OK, message changed.

I enclose the patch on #6 adapted to work on branch 7.x-2.x. The only rejected code for patch #6 on branch 7.x-2.x is the following (views_php_plugin_pager.inc.rej):

***************
*** 37,51 ****
        }
      }
  
-     $this->wrapped->total_items = count($this->wrapped->view->result);
-     $this->wrapped->update_page_info();
- 
-     $item_per_page = $this->wrapped->get_items_per_page();
-     if ($item_per_page > 0) {
-       $offset = $this->wrapped->get_current_page() * $item_per_page + $this->wrapped->get_offset();
-       $this->wrapped->view->result = array_slice($this->wrapped->view->result, $offset, $item_per_page);
      }
-     $this->wrapped->post_execute($result);
    }
  
  
--- 39,55 ----
        }
      }
  
+     if (!empty($this->wrapped->view->views_php_query_all)) {
+       $this->wrapped->total_items = count($this->wrapped->view->result);
+       $this->wrapped->update_page_info();
+ 
+       $item_per_page = $this->wrapped->get_items_per_page();
+       if ($item_per_page > 0) {
+         $offset = $this->wrapped->get_current_page() * $item_per_page + $this->wrapped->get_offset();
+         $this->wrapped->view->result = array_slice($this->wrapped->view->result, $offset, $item_per_page);
+       }
+       $this->wrapped->post_execute($result);
      }
    }

I have created an issue fork and merge request with the patch from #6.

this project needs a new maintainer , the current maintainers have not been active for a while (look at the project page), I suggest pinging all of them and asking for maintainer priviledges.

Re-rolled patch #6. Please review.

Thank you. I would appreciate it if you would update the issue fork.

I'm moving towards making a release. I would like to get this in. The issue fork needs to be rebased and it needs to be tested back to RTBC. Thanks.

Reroll from #15 works fine with 7.x-1.0-beta1! Thanks!

Found a small bug in #15. Fixed.

Please update the issue fork.