Fieldgroup not render override template

There is the same or a similar similar behaviour using Field Group with a Display Suite layout. According to information of the following threads, the problem should be solved if you apply three patches regarding Drupal Core, Display Suite and Field Group:

Core: Field UI table is broken for nested elements
Display Suite: Field group compatibility
Field Group: Fields are not grouped when render element key is not elements

I updated to the relevant dev versions of Core, DS and FG, but when I create a field group, e.g. "HTML element" in a Display Suite layout, e.g. "One column", the field group still doesn't shows up on the node. (In contrast, it shows up if I deacitivate the Display Suite layout.)

So, possibly a new incompatibility between Display Suite and Field Group? (I'm posting here in the Field Group queue, because I found the active issue of vanilla-bear.)

This issue could be related. #2594123: fix for ds registry alter, variants of templates did not get picked up
Let me install and see if I can figure out the issue, the summary is a bit confusing.

Well apparently there are still issues with DS and field group, but this issue is something different

Can you try the following code, it's super ugly but at least it should work, but it can cause issues if there is a template that start with "node".

/**
 * Implements hook_theme_registry_alter().
 */
function field_group_theme_registry_alter(&$theme_registry) {

  // Inject field_group_build_entity_groups in all entity theming functions.
  $entity_info = Drupal::entityManager()->getDefinitions();
  $entity_types = array();
  foreach ($entity_info as $entity_type_id => $entity_type) {
    if ($route_name = $entity_type->get('field_ui_base_route')) {
      $entity_types[] = $entity_type_id;
    }
  }

  foreach ($entity_types as $entity_type) {
    foreach ($theme_registry as $theme_registry_item_key => $theme_registry_item) {
      if (substr($theme_registry_item_key, 0, strlen($entity_type)) == $entity_type) {
        $theme_registry[$entity_type]['preprocess functions'][] = 'field_group_build_entity_groups';
        // DS support, make sure it comes after field_group.
        if ($key = array_search('ds_preprocess_ds_layout', $theme_registry[$entity_type]['preprocess functions'])) {
          unset($theme_registry[$entity_type]['preprocess functions'][$key]);
          $theme_registry[$entity_type]['preprocess functions'][] = 'ds_preprocess_ds_layout';
        }
      }
    }
  }
}

@aspilicious: At which place should one try the proposed code?

Hi,

I am working on this issue and I have this problem without DS enabled. So it seems like a field_group problem.
As @aspilicious mentions, It could clash with DS since both modules want to hook in the same process and preferably as last one :) .

I'll update as soon as I localised the problem.

Stalski the problem is the same problem as my linked issue. In D7 you could assign a function to a generic entity template, that also worked for suggestions. In D8 the function needs to be added to each suggestion. Which is not easy, my code is a workaround that potentially can fail. Probably needs a core fix for a beter solution.

Hi

Yes, I kind of figured that :)
Ofcourse the first approach I tried, was the workaround you posted. That is not working for me atm, I'll keep you posted ;)

Going to fix this

Same fix as DS and Layout plugin.

DS support isn't needed as DS added fieldgroup support.
These lines were part of the D7 code I suppose and are incorrect/useless now.

commited and pushed, thanks.