Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Finally got to test the 2.x version, it took some effort and support from recurly to get a propery sandbox installation to test on.
The form succesfully processes transactions and finally accounts are processed reliably by recurly_roles. Thanks for the update!
I'm missing some information on the form though, namely line items and some small things I'll create other issues for.
See screenshot for before and after
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | withoutPatch.jpg | 149.23 KB | Anonymous (not verified) |
| #3 | withPatch.jpg | 173.32 KB | Anonymous (not verified) |
| #3 | recurly-fixed-incorrect-display-items-2626660-3-7.x.patch | 34.36 KB | Anonymous (not verified) |
| #2 | recurly-form-1_x.png | 60.66 KB | JurriaanRoelofs |
| recurly-form.png | 42.22 KB | JurriaanRoelofs | |
Comments
Comment #2
JurriaanRoelofs CreditAttribution: JurriaanRoelofs commentedComment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedHi, i wrote patch for this issue you can check it :)
Comment #4
markdorisonHi @i.kvjatkovskij & @JurriaanRoelofs,
This is a pretty sizable patch with a relatively sparse issue description. Can you update the issue summary with greater detail on the "what" is being changed? I'd be happy to look at the patch for the "how". A good resource: How to create a good issue.
Comment #5
aburke626It looks to me that this is addressing #2626662: Add recurlyjs form validation and markup, #2626672: Make country a select box, and #2616832: Refactor existing CSS for 7.x-3.x as well - which is awesome! But as Mark said above, it would be great to have these broken down into smaller and more digestible patches for review. Thanks!
Comment #6
aburke626Comment #7
JurriaanRoelofs CreditAttribution: JurriaanRoelofs commentedHi, as we went to the live environment suddenly some things were buggy, like sales tax handling and coupon code validation, but we're working on that now and it will probably be fixed today. Also the way we load the library now is depending on the php.ini setting allow_furl_open=On which I don't like to use on production servers so hopefully we can fix that too.
Comment #8
markdorisonComment #9
Chris Matthews CreditAttribution: Chris Matthews commentedThis issue has been postponed for 3 years so closing as outdated. However, please feel free to reopen if necessary.