Problem/Motivation

When using the HTML test mailer plugin, it will serialize the simplenews_mail param which is (probably) a MailEntity object. MailEntity has a reference to the custom cache which may or may not be serializable, IIUC.

Proposed resolution

Remove the reference to the cache when serializing.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 mailentity-serializable-2626358-8.patch627 bytesArla
#5 mailentity-serializable-2626358-5.patch639 bytesArla
#3 mailentity-serializable-2626358-3.patch418 bytesArla
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Arla created an issue. See original summary.

Arla’s picture

Arla
they/them
CreditAttribution: Arla at MD Systems GmbH commented
Title: Make mail cache serializable » Make MailEntity serializable
Arla’s picture

Arla
they/them
CreditAttribution: Arla at MD Systems GmbH commented
FileSize
mailentity-serializable-2626358-3.patch418 bytes
Arla’s picture

Arla
they/them
CreditAttribution: Arla at MD Systems GmbH commented
Status: Active » Needs review
Arla’s picture

Arla
they/them
CreditAttribution: Arla at MD Systems GmbH commented
FileSize
mailentity-serializable-2626358-5.patch639 bytes

Oh, the cache is a service, so we can use DependencySerializationTrait.

The last submitted patch, 3: mailentity-serializable-2626358-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: mailentity-serializable-2626358-5.patch, failed testing.

Arla’s picture

Arla
they/them
CreditAttribution: Arla at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
mailentity-serializable-2626358-8.patch627 bytes

Recreating patch against current head.

Status: Needs review » Needs work

The last submitted patch, 8: mailentity-serializable-2626358-8.patch, failed testing.

Arla’s picture

Arla
they/them
CreditAttribution: Arla at MD Systems GmbH commented
Status: Needs work » Needs review

The last submitted patch, 5: mailentity-serializable-2626358-5.patch, failed testing.

  • Berdir committed 3879a70 on authored by Arla 
    Issue #2626358 by Arla: Make MailEntity serializable
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.