Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Is there a reason outside of typical PHP crazy non-conventional function usage that:
/**
* Load a specific result answer.
*/
function quiz_result_answer_load($result_id, $nid, $vid)
Has a different parameter ordering than other question types such as long_text or short_text answers:
function short_answer_get_answer($question_nid, $question_vid, $result_id)
and:
function long_answer_get_answer($question_nid, $question_vid, $result_id)
When stepping throughout the code to fix other errors and assuming question types derive from a base question coding conventions -- it was ackward see this disparity.
Comment | File | Size | Author |
---|---|---|---|
#2 | parameter_confusion-2626130-2.patch | 4.1 KB | djdevin |
|
Comments
Comment #2
djdevinNope, just general sloppiness over the years :)
Those functions aren't called anymore as of the latest 7.x-5.x-dev, so they're getting removed.
use _quiz_question_response_get_instance()->getResponse() instead
Comment #4
djdevin