Is there a reason outside of typical PHP crazy non-conventional function usage that:

/**
 * Load a specific result answer.
 */
function quiz_result_answer_load($result_id, $nid, $vid)

Has a different parameter ordering than other question types such as long_text or short_text answers:

function short_answer_get_answer($question_nid, $question_vid, $result_id)

and:

function long_answer_get_answer($question_nid, $question_vid, $result_id)

When stepping throughout the code to fix other errors and assuming question types derive from a base question coding conventions -- it was ackward see this disparity.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tenken created an issue. See original summary.

djdevin’s picture

Version: 7.x-5.0-beta3 » 7.x-5.x-dev
Status: Active » Needs review
FileSize
4.1 KB

Nope, just general sloppiness over the years :)

Those functions aren't called anymore as of the latest 7.x-5.x-dev, so they're getting removed.

use _quiz_question_response_get_instance()->getResponse() instead

  • djdevin committed 7212676 on 7.x-5.x
    Issue #2626130 by djdevin, tenken: parameter confusion between question...
djdevin’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.