Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Is there any way to search user in user_points list?
Comment | File | Size | Author |
---|---|---|---|
#9 | implement_user_search_in_user_points_2625644-9.patch | 5.39 KB | ushashree_m |
| |||
#8 | interdiff.txt | 1.57 KB | ushashree_m |
Comments
Comment #2
ushashree_m CreditAttribution: ushashree_m commentedThis patch will add the user search.
Comment #3
Albert Volkman CreditAttribution: Albert Volkman commentedMissing docblock.
This could more simply be written as-
Is the addcslashes() added by db_like() sufficient in escaping user input?
I'd recommend wrapping these in a fieldset, as it'll be more visually appealing.
Refer to https://www.drupal.org/coding-standards/docs#forms for documenting forms and their validation/submission handlers.
"if" should be followed by a space. Also, always use curly braces for conditionals- https://www.drupal.org/coding-standards#controlstruct
Using a drupal_goto() feels incorrect here... Would $form_state['redirect'] work?
This docblock needs to be cleaned up.
I'd prefer to see userpoints_admin_points() refactored to abstract the userpoints model as opposed to creating a new query here.
Comments should begin with a capital letter.
Comment #4
ushashree_m CreditAttribution: ushashree_m commentedHi Albert, Thanks for your suggestions. I have worked on your comments, please check.
Comment #5
Albert Volkman CreditAttribution: Albert Volkman commentedMissing @return
These are already defaulted to FALSE, so these are unnecessary.
If you're going to use a render array, there's no reason to use #markup for a link. Use a link render array.
The isset() is redundant, please remove it.
This should all be on the same line.
Missing variable type.
drupal_json_output() doesn't return, it sends the data to the browser.
Missing docblock entirely.
Comment #6
ushashree_m CreditAttribution: ushashree_m commentedHi Albert, I have Worked on given comments, Please check.
Comment #7
Albert Volkman CreditAttribution: Albert Volkman commentedMissing return type (array).
Missing `@param` and `@return`.
Greater than 80 characters, please shorten. Suggestion: `Menu callback: Retrieve autocomplete suggestions for users with points.`
Comment #8
ushashree_m CreditAttribution: ushashree_m commentedPlease find the updated patch.
Comment #9
ushashree_m CreditAttribution: ushashree_m commentedIn the Previous patch module file changes are not updated. Please find the Updated Patch.
Comment #10
Albert Volkman CreditAttribution: Albert Volkman commented