Coder Sniffer has found some issues with this module.
http://pareview.sh/pareview/httpgitdrupalorgprojectdownloadfilegit

FILE: /var/www/drupal-7-pareview/pareview_temp/download_file.module
---------------------------------------------------------------------------
FOUND 133 ERRORS AND 34 WARNINGS AFFECTING 116 LINES
---------------------------------------------------------------------------
14 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
23 | ERROR | [x] Whitespace found at end of line
25 | ERROR | [x] Concat operator must be surrounded by a single space
25 | ERROR | [x] Concat operator must be surrounded by a single space
30 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
35 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
38 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
39 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
44 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
48 | ERROR | [x] Spaces must be used to indent lines; tabs are not
| | allowed
49 | ERROR | [x] Spaces must be used to indent lines; tabs are not
| | allowed
49 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
50 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
51 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
51 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
60 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.admin.inc'
67 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
73 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
77 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
79 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
81 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
83 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
85 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
87 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
88 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
89 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
90 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
91 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
92 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
93 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
94 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
95 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
96 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
97 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
98 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
99 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
100 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
101 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
102 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
103 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
104 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
105 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
106 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
109 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
111 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
112 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
113 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'download_file.formatter.inc'
114 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
114 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
123 | ERROR | [ ] Missing parameter type
133 | ERROR | [x] Whitespace found at end of line
142 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'bytes'
158 | ERROR | [ ] Missing parameter type
160 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
160 | ERROR | [ ] Return type missing for @return tag in function
| | comment
170 | ERROR | [ ] Missing parameter type
172 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
172 | ERROR | [ ] Return type missing for @return tag in function
| | comment
180 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
182 | ERROR | [x] Whitespace found at end of line
187 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
192 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
197 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
202 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
203 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
207 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
216 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
225 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $items
232 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $items
239 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $items
246 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $items
257 | ERROR | [ ] Missing parameter type
259 | ERROR | [ ] Missing parameter type
261 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
261 | ERROR | [ ] Return type missing for @return tag in function
| | comment
266 | ERROR | [x] Spaces must be used for alignment; tabs are not
| | allowed
267 | ERROR | [x] Expected 1 space before "/"; 0 found
267 | ERROR | [x] Expected 1 space after "/"; 0 found
275 | ERROR | [ ] Missing parameter type
277 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
277 | ERROR | [ ] Return type missing for @return tag in function
| | comment
297 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
297 | ERROR | [x] Whitespace found at end of line
298 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
298 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
308 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
308 | ERROR | [x] Whitespace found at end of line
309 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
309 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
320 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
320 | ERROR | [x] Whitespace found at end of line
321 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
321 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
331 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
331 | ERROR | [x] Whitespace found at end of line
332 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
332 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
345 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
345 | ERROR | [x] Whitespace found at end of line
346 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
346 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
355 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
355 | ERROR | [x] Whitespace found at end of line
356 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
356 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
360 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
360 | ERROR | [x] Whitespace found at end of line
361 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
361 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
366 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
366 | ERROR | [x] Whitespace found at end of line
367 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
367 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
373 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
373 | ERROR | [x] Whitespace found at end of line
374 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
374 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
379 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
379 | ERROR | [x] Whitespace found at end of line
380 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
380 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
385 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
385 | ERROR | [x] Whitespace found at end of line
386 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
386 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
390 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
390 | ERROR | [x] Whitespace found at end of line
391 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
391 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
396 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
396 | ERROR | [x] Whitespace found at end of line
397 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
397 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
402 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
402 | ERROR | [x] Whitespace found at end of line
403 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
403 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
407 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
407 | ERROR | [x] Whitespace found at end of line
408 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
408 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
416 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
416 | ERROR | [x] Whitespace found at end of line
417 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
417 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
424 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
424 | ERROR | [x] Whitespace found at end of line
425 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
425 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
426 | ERROR | [x] Whitespace found at end of line
431 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
431 | ERROR | [x] Whitespace found at end of line
432 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
432 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
437 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
437 | ERROR | [x] Whitespace found at end of line
438 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
438 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
445 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
445 | ERROR | [x] Whitespace found at end of line
446 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
446 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
457 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
457 | ERROR | [x] Whitespace found at end of line
458 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 18
458 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
463 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 150 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/download_file.install
---------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 7 LINES
---------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
4 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
9 | ERROR | [x] Whitespace found at end of line
15 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
28 | ERROR | [x] Whitespace found at end of line
31 | ERROR | [x] Whitespace found at end of line
34 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/download_file.info
---------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
5 | ERROR | [ ] It's only necessary to declare files[] if they declare a
| | class or interface.
6 | ERROR | [ ] It's only necessary to declare files[] if they declare a
| | class or interface.
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/download_file.formatter.inc
---------------------------------------------------------------------------
FOUND 63 ERRORS AND 5 WARNINGS AFFECTING 55 LINES
---------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
6 | ERROR | [ ] Missing parameter type
8 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
8 | ERROR | [ ] Return type missing for @return tag in function
| | comment
16 | ERROR | [x] Whitespace found at end of line
25 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
27 | ERROR | [ ] Missing parameter type
29 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
29 | ERROR | [ ] Return type missing for @return tag in function
| | comment
37 | ERROR | [x] Whitespace found at end of line
46 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
48 | ERROR | [ ] Missing parameter type
50 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
50 | ERROR | [ ] Return type missing for @return tag in function
| | comment
58 | ERROR | [x] Whitespace found at end of line
67 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
69 | ERROR | [ ] Missing parameter type
71 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
71 | ERROR | [ ] Return type missing for @return tag in function
| | comment
79 | ERROR | [x] Whitespace found at end of line
90 | ERROR | [ ] Missing parameter type
92 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
92 | ERROR | [ ] Return type missing for @return tag in function
| | comment
97 | ERROR | [x] Whitespace found at end of line
114 | ERROR | [x] Use "elseif" in place of "else if"
117 | ERROR | [x] Whitespace found at end of line
127 | ERROR | [ ] Missing parameter type
129 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
129 | ERROR | [ ] Return type missing for @return tag in function
| | comment
134 | ERROR | [x] Whitespace found at end of line
152 | ERROR | [x] Use "elseif" in place of "else if"
155 | ERROR | [x] Whitespace found at end of line
165 | ERROR | [ ] Missing parameter type
167 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
167 | ERROR | [ ] Return type missing for @return tag in function
| | comment
172 | ERROR | [x] Whitespace found at end of line
190 | ERROR | [x] Use "elseif" in place of "else if"
193 | ERROR | [x] Whitespace found at end of line
201 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
203 | ERROR | [ ] Missing parameter type
205 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
205 | ERROR | [ ] Return type missing for @return tag in function
| | comment
210 | ERROR | [x] Whitespace found at end of line
229 | ERROR | [x] Use "elseif" in place of "else if"
232 | ERROR | [x] Whitespace found at end of line
242 | ERROR | [ ] Missing parameter type
244 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
244 | ERROR | [ ] Return type missing for @return tag in function
| | comment
250 | ERROR | [x] Whitespace found at end of line
255 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
255 | ERROR | [x] Concat operator must be surrounded by a single space
261 | ERROR | [ ] Missing parameter type
263 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
263 | ERROR | [ ] Return type missing for @return tag in function
| | comment
268 | ERROR | [x] Whitespace found at end of line
272 | ERROR | [x] Whitespace found at end of line
279 | ERROR | [ ] Missing parameter type
281 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
281 | ERROR | [ ] Return type missing for @return tag in function
| | comment
286 | ERROR | [x] Whitespace found at end of line
292 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
293 | ERROR | [x] Array indentation error, expected 4 spaces but found
| | 28
294 | ERROR | [x] Array indentation error, expected 4 spaces but found
| | 28
295 | ERROR | [x] Array indentation error, expected 4 spaces but found
| | 28
296 | ERROR | [x] Array indentation error, expected 4 spaces but found
| | 28
297 | ERROR | [x] Array indentation error, expected 4 spaces but found
| | 28
297 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
300 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 41 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/download_file.admin.inc
---------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
---------------------------------------------------------------------------
19 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: TRUE
21 | ERROR | [x] Whitespace found at end of line
30 | ERROR | [x] Whitespace found at end of line
34 | ERROR | [x] Use "elseif" in place of "else if"
45 | ERROR | [x] Whitespace found at end of line
57 | ERROR | [x] Whitespace found at end of line
59 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
CommentFileSizeAuthor
#2 2624760-2.patch22.87 KBkrknth
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

krknth created an issue. See original summary.

krknth’s picture

Assigned: krknth » Unassigned
Status: Active » Needs review
FileSize
22.87 KB

Fixed coder module warning!
needs review.

neerajskydiver’s picture

Status: Needs review » Reviewed & tested by the community

This patch fixes warnings from coder.

Thanks

neerajskydiver’s picture

Status: Reviewed & tested by the community » Fixed

committed! 134114f

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.