Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
While searching for crazy commits, I found #2078101: Update year in COPYRIGHT.txt and #1012018: COPYRIGHT.txt still thinks it's 2010 and is missing some entries so I'm bringing this up again, with a patch to fix the year for D8.
Afterhours drupal fun :)
Comment | File | Size | Author |
---|---|---|---|
#25 | interdiff-2624024-17-24.txt | 674 bytes | wturrell |
#24 | update_year_in_copyright-2624024-24.patch | 1.22 KB | wturrell |
#18 | interdiff-2624024-2-17.txt | 947 bytes | rajeshwari10 |
#17 | update_year_in_copyright-2624024-17.patch | 1.21 KB | rajeshwari10 |
#2 | update_year_in_copyright-2624024-2.patch | 425 bytes | bserem |
Comments
Comment #2
bserem CreditAttribution: bserem as a volunteer commentedI'd like to submit this for the TPOTM award too!
Comment #3
thpoul CreditAttribution: thpoul as a volunteer commentedSymfony2 - Copyright (c) 2004 - 2012 Fabien Potencier
needs to change toSymfony2 - Copyright (c) 2004 - 2015 Fabien Potencier
Source: http://symfony.com/doc/current/contributing/code/license.htmlTwig - Copyright (c) 2009 Twig Team
also needs to change toTwig - Copyright (c) 2009 - 2014 by the Twig Team
Source: http://twig.sensiolabs.org/licenseComment #4
cilefen CreditAttribution: cilefen commented@thpoul This makes me wonder how many other libraries ship with Drupal that are not mentioned in this file. And, why we would need to mention them at all because most, if not, all should ship with their own copyright notices.
Based on (emphasis mine)...
...it is a partial list. But what is the standard for including a given library's copyright in this file?
I wonder if the Licensing Working Group could help.
Comment #5
cilefen CreditAttribution: cilefen commentedComment #6
cilefen CreditAttribution: cilefen commentedOk, one more tag, sorry about the noise.
Comment #7
cilefen CreditAttribution: cilefen commentedSorry!
Comment #8
bserem CreditAttribution: bserem as a volunteer commentedI don't see how the rest of the years in the copyright file should be targeted all together in one issue.
We know for sure that the Drupal year need to be updated.
I'll bump this up again, so that it might catch some attention and we get more feedback.
I could do a research and update the information on all/most projects used in D8, if thats what we decide to do.
Comment #9
cilefen CreditAttribution: cilefen commented@bserem From what I read via Google and my very limited understanding of copyright, it may be that only the first year need be listed. But, take that with a grain of salt.
Comment #11
frankfarm CreditAttribution: frankfarm as a volunteer commentedFrom #4:
I agree that one or more lawyers familiar with copyright law (international or U.S.) ought to weigh in. Is there a recommended way to bring this issue to that group's attention?
Regarding #9, it might also be the case that no start and no end year is required; I'm just not sure.
Comment #12
cilefen CreditAttribution: cilefen commentedI opened #2725083: Are the years necessary in a copyright declaration?, but how about as per #8 we just mark this RTBC and get it fixed?
Comment #13
John Cook CreditAttribution: John Cook commentedI'm putting this back to RTBC.
I do not believe that we should be changing the copyright messages in third party software (Symphony, Twig, etc). There may be a reason for that specific year / range that we are unaware of.
Therefore, we should only change the copyright messages for Drupal itself and leave all other copyright notices as is.
Comment #14
cilefen CreditAttribution: cilefen commented@John Cook: It turns out that is the future, but it isn't the current policy. See the discussion on #2725083: Are the years necessary in a copyright declaration?
In light of the actual policy, I think we have got missing a few 3rd-party licenses in COPYRIGHT.txt.
Comment #15
John Cook CreditAttribution: John Cook commentedSet to Needs work because of the comment from cilefen and the contents of COPYRIGHT.txt.
On 8.2.x before running
composer install
, so it's just the drupal repo, I have run the following command:grep -irn "Copyright .*\-.*20[01][0-9]" * | grep -v "\-.*2016"
This should get any copyright notices not ending with 2016.
The results are as follows:
Just to note this is without the patch applied.
Comment #16
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commentedComment #17
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commentedUpdated years in the copyright.
Please review.
Thanks!!
Comment #18
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commentedAdding interdiff.
Comment #20
John Cook CreditAttribution: John Cook commentedTest bot being silly.
Comment #22
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commentedHi John Cook,
I don't know why the bot is saying failed testing.
Please review it.
Thanks!!
Comment #24
wturrell CreditAttribution: wturrell as a volunteer commentedHappy New Year.
Comment #25
wturrell CreditAttribution: wturrell as a volunteer commentedInterdiff.
Comment #26
wturrell CreditAttribution: wturrell as a volunteer commentedComment #33
quietone CreditAttribution: quietone as a volunteer commentedThank you all for working on bringing the copyright file up to date.
The copyright file was updated on 15 May 2020 in #3119733: COPYRIGHT.txt outdated.