Problem/Motivation
From #2618040-45: Configuration of configurable language types reset after module install:
why do we do this here instead of a change in updateConfiguration()
I think we should look at that in a follow-up, my original patch was hoping that would work already (clearly it doesn't), but it'd also be a behaviour change so something we should change in 8.1.x.
Proposed resolution
Make the parameter optional and default to the current configuration, i.e. \Drupal::config('language.types')->get('configurable');
.
Remaining tasks
Do it
User interface changes
None
API changes
Only additive
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#21 | 2623906-nr-bot.txt | 1.46 KB | needs-review-queue-bot |
#13 | 2623906-13.patch | 1011 bytes | lmancilla |
Comments
Comment #2
plachComment #3
plachFirst draft, feel free to take this over :)
Comment #4
YesCT CreditAttribution: YesCT commentedI'll close #2623788: updateConfiguration() should be able to override configurable of language types when modules are installed or uninstalled as a duplicate.
Comment #13
lmancilla CreditAttribution: lmancilla at Globant commentedI wonder why it is necessary to have the language negotiation URL and URL fallback as fixed,
in our case that was overwriting our configuration and our custom language negotiation methods were being disabled.
as a workaround, i removed the Language Negotiation fixed by Core using hook_language_types_info_alter.
unset($language_types[LanguageInterface::TYPE_URL]['fixed']);
Could we consider to remove the Core default Language negotiation methods as fixed?
Comment #16
JamieP CreditAttribution: JamieP commentedComment #21
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.