Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In the 'happened to stumble across it while reading code' category:
The SessionManager::migrateStoredSession() comment still mentions $new_insecure_session_id, which has been removed in #2342593: Remove mixed SSL support from core. Apparently the issue forgot to reword this particular line.
(It does not need to be replaced by something else; this functionality is indeed completely removed.
I don't think rewording the $this->getId() bit is necessary. It's a protected function.)
Comment | File | Size | Author |
---|---|---|---|
#5 | sessionmanager-migratestored-2623790-5.patch | 729 bytes | priya.chat |
sessionmanager-migratestored.patch | 729 bytes | roderik | |
Comments
Comment #2
stefan.r CreditAttribution: stefan.r commentedThis fix makes sense! Before #2342593: Remove mixed SSL support from core $new_insecure_session_id used to overwrite $fields['sid'] but now $fields['sid'] always a base64 hashed $this->getId() and we're not overwriting it anymore.
Comment #3
jhodgdonCan you also fix this?
id => ID
Thanks!
Comment #4
priya.chat CreditAttribution: priya.chat at Publicis Sapient for Publicis Sapient commentedComment #5
priya.chat CreditAttribution: priya.chat at Publicis Sapient for Publicis Sapient commentedHello, I have added the mentioned change in the previous patch. Please review.
Comment #6
stefan.r CreditAttribution: stefan.r commentedComment #7
jhodgdonThanks! Committed to both 8.x branches.