Problem/Motivation

Right now we print multiple attributes objects in a row which in some cases causes same attribute being printed multiple times.

Proposed resolution

Figure out a way to merge attributes objects.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2623702-fix-merging-attributes-8.patch3.66 KBaspilicious
#3 2623702-fix-merging-attributes.patch3.53 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Should be fixed in core...

#2623960: Improve the merge() method on Attribute objects

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Active » Needs review
FileSize
2623702-fix-merging-attributes.patch3.53 KB

Let's see if this brakes, it could be that some tests fail because they are incorrect in HEAD :)

Status: Needs review » Needs work

The last submitted patch, 3: 2623702-fix-merging-attributes.patch, failed testing.

The last submitted patch, 3: 2623702-fix-merging-attributes.patch, failed testing.

The last submitted patch, 3: 2623702-fix-merging-attributes.patch, failed testing.

The last submitted patch, 3: 2623702-fix-merging-attributes.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
2623702-fix-merging-attributes-8.patch3.66 KB

  • aspilicious committed 5b04874 on 8.x-2.x 
    Issue #2623702 by aspilicious: HTML Attributes not merged properly
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.